Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40689: [Docs] Add nanoarrow to implementation status page #41052

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Apr 6, 2024

Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

Are these changes tested?

Not needed (docs!)

Are there any user-facing changes?

No (docs!)

Copy link

github-actions bot commented Apr 6, 2024

⚠️ GitHub issue #40689 has been automatically assigned in GitHub to PR creator.

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Apr 6, 2024

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8582761059

@kou
Copy link
Member

kou commented Apr 6, 2024

@github-actions crossbow submit preview-docs

@kou
Copy link
Member

kou commented Apr 6, 2024

@paleolimbot Could you change your visibility to "Public" from "Private" in the "apache" organization to use @github-actions crossbow submit?
See also: https://github.com/orgs/apache/people?query=paleolimbot

Copy link

github-actions bot commented Apr 6, 2024

Revision: cb81cda

Submitted crossbow builds: ursacomputing/crossbow @ actions-8465c6de82

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 8, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Apr 8, 2024
@ianmcook
Copy link
Member

ianmcook commented Apr 9, 2024

@paleolimbot some of these tables are getting so wide that the layout risks breaking. One easy way to improve this is to replace all JavaScript with JS in the header rows. Could you do that please?

To further minimize width, perhaps also change nanoarrow to nano in the header rows, and include this at the end of the paragraph at the top of the page:

"nano" refers to nanoarrow_.

.. _nanoarrow: https://arrow.apache.org/nanoarrow/

While you're editing this file, can you fix the two places in the tables where there's a × instead of a ?

@ianmcook
Copy link
Member

ianmcook commented Apr 9, 2024

I think it would also be good to add nanoarrow to the Implementations drop-down. You can add it here between MATLAB and Python:

   nanoarrow <https://arrow.apache.org/nanoarrow/>

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 9, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 9, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Revision: 3637c2a

Submitted crossbow builds: ursacomputing/crossbow @ actions-45d3a340b4

Task Status
preview-docs GitHub Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Apr 9, 2024

Revision: 3637c2a

Submitted crossbow builds: ursacomputing/crossbow @ actions-e4736958c9

Task Status
preview-docs GitHub Actions

@paleolimbot
Copy link
Member Author

Thank you for taking a look!

One easy way to improve this is to replace all JavaScript with JS in the header rows. Could you do that please?

Done!

I think it would also be good to add nanoarrow to the Implementations drop-down.

Done!

To further minimize width, perhaps also change nanoarrow to nano in the header rows

I don't mind doing this; however, I did check a variety of page widths and at the point where the page is on vertical mobile it already cuts off just after JavaScript. A longer term solution might be to transpose the table and repartition the features a bit rather than add another column.

docs/source/status.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 9, 2024
@paleolimbot
Copy link
Member Author

@github-actions crossbow submit preview-docs

Copy link

github-actions bot commented Apr 9, 2024

Revision: 167df74

Submitted crossbow builds: ursacomputing/crossbow @ actions-e98970d8ec

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 9, 2024
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Apr 9, 2024
@paleolimbot paleolimbot merged commit dbedcfc into apache:main Apr 9, 2024
8 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Apr 9, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dbedcfc.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

raulcd pushed a commit that referenced this pull request Apr 10, 2024
### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: #40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
verma-kartik pushed a commit to verma-kartik/arrow that referenced this pull request Apr 11, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Apr 15, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot deleted the docs-nanoarrow-status branch April 17, 2024 14:07
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 4, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…pache#41052)

### Rationale for this change

nanoarrow now supports most types and reading IPC streams. As discussed in the issue, there is interest in adding it to the implementation status page for visibility.

### What changes are included in this PR?

A column was added to the table with the appropriate values characterizing the C library implementation status.

### Are these changes tested?

Not needed (docs!)

### Are there any user-facing changes?

No (docs!)
* GitHub Issue: apache#40689

Lead-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants