GH-40801: [Docs] Clarify device identifier documentation in the Arrow C Device data interface #41101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jorisvandenbossche
approved these changes
Apr 9, 2024
|
cc @kkraus14 |
github-actions
bot
added
awaiting merge
kkraus14
approved these changes
Apr 9, 2024
raulcd
approved these changes
Apr 10, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6e1b625. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
raulcd
pushed a commit
that referenced
this pull request
Apr 11, 2024
… C Device data interface (#41101) ### Rationale for this change It is not explicit what the value of the `ArrowDeviceArray::device_id` should be when a given device type has no notion of a device identifier (e.g., there is always only one). ### What changes are included in this PR? The text was clarified to recommend a value of -1. This was the value already used by Arrow C++. ### Are these changes tested? No tests needed (documentation) ### Are there any user-facing changes? No * GitHub Issue: #40801 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
Apr 15, 2024
… Arrow C Device data interface (apache#41101) ### Rationale for this change It is not explicit what the value of the `ArrowDeviceArray::device_id` should be when a given device type has no notion of a device identifier (e.g., there is always only one). ### What changes are included in this PR? The text was clarified to recommend a value of -1. This was the value already used by Arrow C++. ### Are these changes tested? No tests needed (documentation) ### Are there any user-facing changes? No * GitHub Issue: apache#40801 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
… Arrow C Device data interface (apache#41101) ### Rationale for this change It is not explicit what the value of the `ArrowDeviceArray::device_id` should be when a given device type has no notion of a device identifier (e.g., there is always only one). ### What changes are included in this PR? The text was clarified to recommend a value of -1. This was the value already used by Arrow C++. ### Are these changes tested? No tests needed (documentation) ### Are there any user-facing changes? No * GitHub Issue: apache#40801 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
… Arrow C Device data interface (apache#41101) ### Rationale for this change It is not explicit what the value of the `ArrowDeviceArray::device_id` should be when a given device type has no notion of a device identifier (e.g., there is always only one). ### What changes are included in this PR? The text was clarified to recommend a value of -1. This was the value already used by Arrow C++. ### Are these changes tested? No tests needed (documentation) ### Are there any user-facing changes? No * GitHub Issue: apache#40801 Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It is not explicit what the value of the
ArrowDeviceArray::device_idshould be when a given device type has no notion of a device identifier (e.g., there is always only one).What changes are included in this PR?
The text was clarified to recommend a value of -1. This was the value already used by Arrow C++.
Are these changes tested?
No tests needed (documentation)
Are there any user-facing changes?
No