Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41114: [C++] Add is_validity_defined_by_bitmap() predicate #41115

Merged
merged 5 commits into from
Apr 23, 2024
Merged

GH-41114: [C++] Add is_validity_defined_by_bitmap() predicate #41115

merged 5 commits into from
Apr 23, 2024

Commits on Apr 9, 2024

  1. data.h: Add is_validity_defined_by_bitmap() predicate

    @felipecrv
    felipecrv committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a371653 View commit details
    Browse the repository at this point in the history

  2. builder_nested.h: Use validity bitmap directly instead of calling IsV… 

    …alid()

The constexpr is_validity_defined_by_bitmap() predicate guarantees
statically that it's enough to look only at the bitmap for the types
these templates are used with.
    @felipecrv
    felipecrv committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0a849e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. type.h: Introduce may_have_validity_bitmap() and deprecate HasValidit… 

    …yBitmap()
    @felipecrv
    felipecrv committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    097c37a View commit details
    Browse the repository at this point in the history

  2. Delete is_validity_defined_by_bitmap in favor of may_have_validity_bi… 

    …tmap
    @felipecrv
    felipecrv committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4187b31 View commit details
    Browse the repository at this point in the history

  3. Fix deprecation warnings/errors

    @felipecrv
    felipecrv committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7b9a2e7 View commit details
    Browse the repository at this point in the history