Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41147: [CI][C++] Use newer LLVM on Ubuntu 24.04 #41150

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 11, 2024

What changes are included in this PR?

Use LLVM 15 on Ubuntu 24.04, as LLVM 14 packages seem not always available.

Are these changes tested?

Yes, on CI.

Are there any user-facing changes?

No.

@pitrou
Copy link
Member Author

pitrou commented Apr 11, 2024

@github-actions crossbow submit 24.04

Copy link

⚠️ GitHub issue #41147 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 11, 2024
Copy link

Revision: 9106472

Submitted crossbow builds: ursacomputing/crossbow @ actions-68f62c719d

Task Status
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions

@pitrou pitrou force-pushed the gh41147-24.04-llvm-version branch from 9106472 to afe018e Compare April 11, 2024 13:01
@pitrou
Copy link
Member Author

pitrou commented Apr 11, 2024

@github-actions crossbow submit test-ubuntu-24.04-cpp

Copy link

Revision: afe018e

Submitted crossbow builds: ursacomputing/crossbow @ actions-1ed5bc1137

Task Status
test-ubuntu-24.04-cpp GitHub Actions

@pitrou pitrou marked this pull request as ready for review April 11, 2024 13:19
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 11, 2024
@pitrou pitrou merged commit effd5af into apache:main Apr 11, 2024
52 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Apr 11, 2024
@pitrou pitrou deleted the gh41147-24.04-llvm-version branch April 11, 2024 14:01
raulcd pushed a commit that referenced this pull request Apr 11, 2024
### What changes are included in this PR?

Use LLVM 15 on Ubuntu 24.04, as LLVM 14 packages seem not always available.

### Are these changes tested?

Yes, on CI.

### Are there any user-facing changes?

No.
* GitHub Issue: #41147

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit effd5af.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Apr 15, 2024
### What changes are included in this PR?

Use LLVM 15 on Ubuntu 24.04, as LLVM 14 packages seem not always available.

### Are these changes tested?

Yes, on CI.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41147

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
### What changes are included in this PR?

Use LLVM 15 on Ubuntu 24.04, as LLVM 14 packages seem not always available.

### Are these changes tested?

Yes, on CI.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41147

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### What changes are included in this PR?

Use LLVM 15 on Ubuntu 24.04, as LLVM 14 packages seem not always available.

### Are these changes tested?

Yes, on CI.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#41147

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants