Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41177

Merged
merged 1 commit into from
Apr 13, 2024
Merged

GH-41176: [C++] Stop defining ARROW_TEST_MEMCHECK in config.h.cmake #41177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/src/arrow/filesystem/test_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "arrow/testing/future_util.h"
#include "arrow/testing/gtest_util.h"
#include "arrow/util/async_generator.h"
#include "arrow/util/config.h"
#include "arrow/util/io_util.h"
#include "arrow/util/key_value_metadata.h"
#include "arrow/util/vector.h"
Expand Down Expand Up @@ -753,7 +752,7 @@ void GenericFileSystemTest::TestGetFileInfoSelector(FileSystem* fs) {
}

void GenericFileSystemTest::TestGetFileInfoGenerator(FileSystem* fs) {
#if defined(ADDRESS_SANITIZER) || defined(ARROW_TEST_MEMCHECK)
#if defined(ADDRESS_SANITIZER) || defined(ARROW_VALGRIND)
if (have_false_positive_memory_leak_with_generator()) {
GTEST_SKIP() << "Filesystem have false positive memory leak with generator";
}
Expand Down
1 change: 0 additions & 1 deletion cpp/src/arrow/util/config.h.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
#cmakedefine ARROW_GCS
#cmakedefine ARROW_HDFS
#cmakedefine ARROW_S3
#cmakedefine ARROW_TEST_MEMCHECK
#cmakedefine ARROW_USE_GLOG
#cmakedefine ARROW_USE_NATIVE_INT128
#cmakedefine ARROW_WITH_BROTLI
Expand Down
Loading