Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] refactor: move aggregation function bindings to their own file #41355

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

nealrichardson
Copy link
Member

For consistency with other bindings, and to allow dplyr-summarize.R to start with the summarize method, as do the other dplyr verb files.

@nealrichardson nealrichardson requested review from jonkeane and removed request for paleolimbot and thisisnic April 23, 2024 15:48
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 23, 2024
@nealrichardson nealrichardson merged commit f1bc82f into apache:main Apr 23, 2024
11 checks passed
@nealrichardson nealrichardson deleted the move-agg-funcs branch April 23, 2024 17:31
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f1bc82f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Apr 24, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
tolleybot pushed a commit to tmct/arrow that referenced this pull request May 4, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
rok pushed a commit to tmct/arrow that referenced this pull request May 8, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…file (apache#41355)

For consistency with other bindings, and to allow `dplyr-summarize.R` to
start with the summarize method, as do the other dplyr verb files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants