GH-41681: [GLib] Generate separate version macros for each GLib library #41721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: Gandiva
Component: GLib
awaiting review
kou
reviewed
May 20, 2024
github-actions
bot
added
awaiting changes
kou
reviewed
May 20, 2024
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting merge
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 37e5240. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them. |
adamreeve
commented
May 22, 2024
| G_BEGIN_DECLS | ||
|
|
||
| #define GGANDIVA_TYPE_NODE (ggandiva_node_get_type()) | ||
| GGANDIVA_AVAILABLE_IN_0_12; |
Contributor
Author
There was a problem hiding this comment.
I just noticed I accidentally added semicolons at the end of the macros in this header, which causes a problem when the macros get replaced with something. I can fix this as part of #41599
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
… library (apache#41721) ### Rationale for this change This is to support later using the `*_AVAILABLE_IN_*` macros to add `dllexport/dllimport` attributes required for building these libraries with MSVC (apache#41134) ### What changes are included in this PR? * Add a Python script that generates `DEPRECATED_IN` and `AVAILABLE_IN` macros for each GLib library * Add missing `AVAILABLE_IN` annotations to some methods in the GLib libraries (except the main arrow-glib library as this is being done in apache#41599) ### Are these changes tested? This doesn't include any behaviour change that can be unit tested. ### Are there any user-facing changes? No * GitHub Issue: apache#41681 Lead-authored-by: Adam Reeve <adreeve@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is to support later using the
*_AVAILABLE_IN_*macros to adddllexport/dllimportattributes required for building these libraries with MSVC (#41134)What changes are included in this PR?
DEPRECATED_INandAVAILABLE_INmacros for each GLib libraryAVAILABLE_INannotations to some methods in the GLib libraries (except the main arrow-glib library as this is being done in GH-41134: [GLib] Support building arrow-glib with MSVC #41599)Are these changes tested?
This doesn't include any behaviour change that can be unit tested.
Are there any user-facing changes?
No