Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-41749: [GLib] Allow getting a RecordBatchReader from a Dataset or Scanner #41750

Merged
merged 9 commits into from
May 25, 2024
Merged

GH-41749: [GLib] Allow getting a RecordBatchReader from a Dataset or Scanner #41750

merged 9 commits into from
May 25, 2024

Commits on May 21, 2024

  1. Allow getting a record batch reader for a dataset or scanner

    @adamreeve
    adamreeve committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f775c80 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @adamreeve
    adamreeve committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c5b890e View commit details
    Browse the repository at this point in the history

  3. Use to_reader rather than get_reader

    @adamreeve
    adamreeve committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d1d9765 View commit details
    Browse the repository at this point in the history

  4. Use RecordBatchReader.read_all in tests 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @adamreeve @kou
    adamreeve and kou authored May 21, 2024
    Configuration menu
    Copy the full SHA
    729eeb9 View commit details
    Browse the repository at this point in the history

  5. Rename method to to_record_batch_reader

    @adamreeve
    adamreeve committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7f5222b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge remote-tracking branch 'upstream/main' into glib_dataset_reader

    @adamreeve
    adamreeve committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1689d7c View commit details
    Browse the repository at this point in the history

  2. Ignore errors removing dataset directory and add GC.start

    @adamreeve
    adamreeve committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4058984 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @adamreeve @kou
    adamreeve and kou authored May 25, 2024
    Configuration menu
    Copy the full SHA
    0475ad6 View commit details
    Browse the repository at this point in the history

  2. Use unref to free readers

    @adamreeve
    adamreeve committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0dba622 View commit details
    Browse the repository at this point in the history