Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Python] try harder to set up s3_server fixture #41754

Merged
merged 1 commit into from
May 23, 2024

Conversation

h-vetinari
Copy link
Contributor

In conda-forge, when running the aarch tests in emulation, we regularly run into the issue that the fixture setup fails. Extending the timeouts fixes this. Since it only happens once per session, it doesn't hurt to take a little bit more time.

it only happens once per session, so we may as well take the time
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@jorisvandenbossche jorisvandenbossche changed the title [python] try harder to set up s3_server fixture [Python] try harder to set up s3_server fixture May 21, 2024
@h-vetinari h-vetinari changed the title [Python] try harder to set up s3_server fixture MINOR: [Python] try harder to set up s3_server fixture May 21, 2024
@pitrou pitrou merged commit 84b9a19 into apache:main May 23, 2024
15 checks passed
@pitrou pitrou removed the awaiting review Awaiting review label May 23, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 23, 2024
@h-vetinari h-vetinari deleted the s3_server branch May 23, 2024 15:29
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 84b9a19.

There were 6 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 244 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
In conda-forge, when running the aarch tests in emulation, we regularly run into the [issue](conda-forge/pyarrow-feedstock#117) that the fixture setup fails. Extending the timeouts fixes this. Since it only happens once per session, it doesn't hurt to take a little bit more time.

Authored-by: H. Vetinari <h.vetinari@gmx.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants