MINOR: [C++] Slight improvement for ArrayData device_type #41814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
pitrou
reviewed
May 28, 2024
| if (type == 0) { | ||
| type = static_cast<int>(buf->device_type()); | ||
| } else { | ||
| DCHECK_EQ(type, static_cast<int>(buf->device_type())); | ||
| } | ||
| #endif | ||
| } | ||
|
|
||
| for (const auto& child : child_data) { | ||
| if (!child) continue; |
There was a problem hiding this comment.
Note that, unlike buffers, this should not happen.
|
FTR, I removed my handle from the PR description, as I don't want to receive notification spam when people merge commits in their Arrow fork :-) |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 235608b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 68 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to feedback on #40807:
Originally posted in #40807 (comment)