Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41397: [C#] Downgrade macOS test runner to avoid infrastructure bug #41934

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Jun 3, 2024

What changes are included in this PR?

Downgrades the macOS test image for C# to use an older operating system. This works around pythonnet/pythonnet#2396.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

github-actions bot commented Jun 3, 2024

⚠️ GitHub issue #41397 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jun 3, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the title GH-41397: [C#] Downgrade MacOS test runner to avoid infrastructure bug GH-41397: [C#] Downgrade macOS test runner to avoid infrastructure bug Jun 3, 2024
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 3, 2024
@kou kou merged commit 7f0c407 into apache:main Jun 3, 2024
10 of 11 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 3, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7f0c407.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants