-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41272: [Java] LargeListViewVector Implementation #43516
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ea50de4
feat: initial partial commit
vibhatha 317fa61
feat: initial partial commit v2
vibhatha e732280
fix: initial build success stage
vibhatha 678ed86
feat: adding the first test case
vibhatha b6b5d61
fix: adding test cases v1
vibhatha 8fafb95
fix: rebase
vibhatha c9674cd
feat: adding test cases v2
vibhatha 5827216
feat: adding other largelistview vector core tests
vibhatha 215735d
fix: largelistview changes for unionlistwriter
vibhatha 5c9aac9
fix: minor docs updates
vibhatha 96b9772
fix: typo
vibhatha 2cabca7
fix: addressing reviews v1
vibhatha 0557737
fix: addressing reviews v2
vibhatha 966ca5a
fix: adding startList, endList
vibhatha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,6 +134,11 @@ | |
name: "ListView", | ||
fields: [], | ||
complex: true | ||
}, | ||
{ | ||
name: "LargeListView", | ||
fields: [], | ||
complex: true | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,6 +41,7 @@ public class PromotableWriter extends AbstractPromotableFieldWriter { | |
protected final ListViewVector listViewVector; | ||
protected final FixedSizeListVector fixedListVector; | ||
protected final LargeListVector largeListVector; | ||
protected final LargeListViewVector largeListViewVector; | ||
protected final NullableStructWriterFactory nullableStructWriterFactory; | ||
protected int position; | ||
protected static final int MAX_DECIMAL_PRECISION = 38; | ||
|
@@ -84,6 +85,7 @@ public PromotableWriter( | |
this.listViewVector = null; | ||
this.fixedListVector = null; | ||
this.largeListVector = null; | ||
this.largeListViewVector = null; | ||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
@@ -118,6 +120,26 @@ public PromotableWriter(ValueVector v, LargeListVector largeListVector) { | |
this(v, largeListVector, NullableStructWriterFactory.getNullableStructWriterFactoryInstance()); | ||
} | ||
|
||
/** | ||
* Constructs a new instance. | ||
* | ||
* @param v The vector to initialize the writer with. | ||
* @param listViewVector The vector that serves as a parent of v. | ||
*/ | ||
public PromotableWriter(ValueVector v, ListViewVector listViewVector) { | ||
this(v, listViewVector, NullableStructWriterFactory.getNullableStructWriterFactoryInstance()); | ||
} | ||
|
||
/** | ||
* Constructs a new instance. | ||
* | ||
* @param v The vector to initialize the writer with. | ||
* @param largeListViewVector The vector that serves as a parent of v. | ||
*/ | ||
public PromotableWriter(ValueVector v, LargeListViewVector largeListViewVector) { | ||
this(v, largeListViewVector, NullableStructWriterFactory.getNullableStructWriterFactoryInstance()); | ||
} | ||
|
||
/** | ||
* Constructs a new instance. | ||
* | ||
|
@@ -134,6 +156,7 @@ public PromotableWriter( | |
this.parentContainer = null; | ||
this.fixedListVector = null; | ||
this.largeListVector = null; | ||
this.largeListViewVector = null; | ||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
@@ -154,6 +177,7 @@ public PromotableWriter( | |
this.parentContainer = null; | ||
this.fixedListVector = null; | ||
this.largeListVector = null; | ||
this.largeListViewVector = null; | ||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
@@ -174,6 +198,7 @@ public PromotableWriter( | |
this.listVector = null; | ||
this.listViewVector = null; | ||
this.largeListVector = null; | ||
this.largeListViewVector = null; | ||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
@@ -194,6 +219,28 @@ public PromotableWriter( | |
this.parentContainer = null; | ||
this.listVector = null; | ||
this.listViewVector = null; | ||
this.largeListViewVector = null; | ||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
||
/** | ||
* Constructs a new instance. | ||
* | ||
* @param v The vector to initialize the writer with. | ||
* @param largeListViewVector The vector that serves as a parent of v. | ||
* @param nullableStructWriterFactory The factory to create the delegate writer. | ||
*/ | ||
public PromotableWriter( | ||
ValueVector v, | ||
LargeListViewVector largeListViewVector, | ||
NullableStructWriterFactory nullableStructWriterFactory) { | ||
this.largeListViewVector = largeListViewVector; | ||
this.fixedListVector = null; | ||
this.parentContainer = null; | ||
this.listVector = null; | ||
this.listViewVector = null; | ||
this.largeListVector = null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ListView is also referenced on lines 279, 344, 389, 575. Do we need to add LargeListView, too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as the above point. |
||
this.nullableStructWriterFactory = nullableStructWriterFactory; | ||
init(v); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ListView is also referenced on lines 163, 187, 210. Do we need to add LargeListView there, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, good point. Arrow Java legacy implementation doesn't seem to support 64-bit cases.The places where I dropped it are similar in that regard. But in case I have really missed, please correct me 😌