-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43672: [C#] Schema should be optional on FlightInfo #43673
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
@CurtHagenlocher - any chance you could give this a quick review please? @CurtHagenlocher - gentle nudge for a review please |
Hi all, sorry to @ so many people but I've had this PR outstanding for review for some time. Would anyone be able to give it a look over and merge if good. I'm keen to get a new release with this added and don't want to fork if possible, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me but I don't have enough knowledge around the C# code base to know whether other changes would be required. I've triggered the CI jobs.
I'm sorry; I forgot about this PR :(. |
Test failure looks unrelated |
Thanks @CurtHagenlocher @raulcd - much appreciated. What's the process for making this into a release? |
This will be part of the 18.0.0. We do quarterly releases and the 18.0.0 release is schedule for next month. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6382c0a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…43673) ### Rationale for this change Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made. ### What changes are included in this PR? ### Are these changes tested? Yes, added a test to confirm this behaviour ### Are there any user-facing changes? * GitHub Issue: apache#43672 Authored-by: neilglover <neilglover@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
…43673) ### Rationale for this change Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made. ### What changes are included in this PR? ### Are these changes tested? Yes, added a test to confirm this behaviour ### Are there any user-facing changes? * GitHub Issue: apache#43672 Authored-by: neilglover <neilglover@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Rationale for this change
Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made.
What changes are included in this PR?
Are these changes tested?
Yes, added a test to confirm this behaviour
Are there any user-facing changes?