-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43378: [Java][CI] Don't configure multithreading when building javadocs #43674
GH-43378: [Java][CI] Don't configure multithreading when building javadocs #43674
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
@github-actions crossbow submit test-debian-12-docs |
Revision: e06d43e Submitted crossbow builds: ursacomputing/crossbow @ actions-660dc2a81f
|
@github-actions crossbow submit test-debian-12-docs |
Revision: 564a719 Submitted crossbow builds: ursacomputing/crossbow @ actions-d4dc0f1198
|
564a719
to
e5f4a77
Compare
@github-actions crossbow submit test-debian-12-docs |
Revision: e5f4a77 Submitted crossbow builds: ursacomputing/crossbow @ actions-0c1dbe8a7e
|
This reverts commit e5f4a77.
@github-actions crossbow submit test-debian-12-docs |
Revision: 5c0bfc6 Submitted crossbow builds: ursacomputing/crossbow @ actions-10ce915a60
|
@github-actions crossbow submit test-debian-12-docs |
Revision: 9fd0026 Submitted crossbow builds: ursacomputing/crossbow @ actions-8f7698b5c5
|
This reverts commit 9fd0026.
|
@github-actions crossbow submit test-debian-12-docs |
Revision: 9fd0026 Submitted crossbow builds: ursacomputing/crossbow @ actions-08d166e83d
|
@github-actions crossbow submit test-debian-12-docs |
Revision: ac61ffd Submitted crossbow builds: ursacomputing/crossbow @ actions-dd7303454f
|
@github-actions crossbow submit test-debian-12-docs |
Revision: f3b7611 Submitted crossbow builds: ursacomputing/crossbow @ actions-74133f613d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Great!
Thanks @danepitkin for fixing this. |
maven-site-plugin is supposedly thread-safe according to https://issues.apache.org/jira/browse/MSITE-873. Should we report the issue upstream? |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fc80d7d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Good point. Should we first try upgrading to latest first? We are using maven-site-plugin v3.12.1 (defined in the parent apache pom I believe), but latest is v4.0.0-M9. |
I'm also not able to reproduce it locally on a different platform (macos). I wonder if it could be that we have an incompatible version matrix configured between the different maven plugins that specifically plagues our CI? |
Actually, I do see this warning from this CI job when trying to reenable multithreading.
https://github.com/ursacomputing/crossbow/actions/runs/10394740527/job/28785211517 |
According to the Jira ticket (https://issues.apache.org/jira/browse/MSITE-873) this was fixed in 3.20+. We just need to upgrade if we want to use multithreading. The best approach is probably to use a later apache parent pom, which does use a later version. |
Rationale for this change
Apparently some maven plugins are not thread safe and started throwing errors in the
test-debian-12-docs
CI job when building javadocs.What changes are included in this PR?
Are these changes tested?
CI
Are there any user-facing changes?
No