Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43378: [Java][CI] Don't configure multithreading when building javadocs #43674

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Aug 13, 2024

Rationale for this change

Apparently some maven plugins are not thread safe and started throwing errors in the test-debian-12-docs CI job when building javadocs.

What changes are included in this PR?

  • Remove multithreading config when building javadocs

Are these changes tested?

CI

Are there any user-facing changes?

No

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Aug 13, 2024
@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: e06d43e

Submitted crossbow builds: ursacomputing/crossbow @ actions-660dc2a81f

Task Status
test-debian-12-docs GitHub Actions

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: 564a719

Submitted crossbow builds: ursacomputing/crossbow @ actions-d4dc0f1198

Task Status
test-debian-12-docs GitHub Actions

@danepitkin danepitkin force-pushed the danepitkin/fix-javadocs-debian-12 branch from 564a719 to e5f4a77 Compare August 13, 2024 15:58
@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: e5f4a77

Submitted crossbow builds: ursacomputing/crossbow @ actions-0c1dbe8a7e

Task Status
test-debian-12-docs GitHub Actions

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

@danepitkin danepitkin changed the title Revert develocity to v1.21.5 [CI] Fix javadoc error Aug 13, 2024
Copy link

Revision: 5c0bfc6

Submitted crossbow builds: ursacomputing/crossbow @ actions-10ce915a60

Task Status
test-debian-12-docs GitHub Actions

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: 9fd0026

Submitted crossbow builds: ursacomputing/crossbow @ actions-8f7698b5c5

Task Status
test-debian-12-docs GitHub Actions

This reverts commit 9fd0026.
@danepitkin danepitkin changed the title [CI] Fix javadoc error [Java][CI] Don't configure multithreading when building javadocs Aug 13, 2024
@danepitkin danepitkin changed the title [Java][CI] Don't configure multithreading when building javadocs GH-43378: [Java][CI] Don't configure multithreading when building javadocs Aug 13, 2024
Copy link

⚠️ GitHub issue #43378 has been automatically assigned in GitHub to PR creator.

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: 9fd0026

Submitted crossbow builds: ursacomputing/crossbow @ actions-08d166e83d

Task Status
test-debian-12-docs GitHub Actions

@danepitkin danepitkin marked this pull request as draft August 13, 2024 19:44
@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

Copy link

Revision: ac61ffd

Submitted crossbow builds: ursacomputing/crossbow @ actions-dd7303454f

Task Status
test-debian-12-docs GitHub Actions

@danepitkin
Copy link
Member Author

@github-actions crossbow submit test-debian-12-docs

@danepitkin danepitkin marked this pull request as ready for review August 13, 2024 21:31
Copy link

Revision: f3b7611

Submitted crossbow builds: ursacomputing/crossbow @ actions-74133f613d

Task Status
test-debian-12-docs GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Great!

@kou kou merged commit fc80d7d into apache:main Aug 13, 2024
21 of 22 checks passed
@kou kou removed the awaiting review Awaiting review label Aug 13, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Aug 13, 2024
@vibhatha
Copy link
Collaborator

Thanks @danepitkin for fixing this.

@laurentgo
Copy link
Collaborator

maven-site-plugin is supposedly thread-safe according to https://issues.apache.org/jira/browse/MSITE-873. Should we report the issue upstream?

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fc80d7d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@danepitkin
Copy link
Member Author

maven-site-plugin is supposedly thread-safe according to https://issues.apache.org/jira/browse/MSITE-873. Should we report the issue upstream?

Good point. Should we first try upgrading to latest first? We are using maven-site-plugin v3.12.1 (defined in the parent apache pom I believe), but latest is v4.0.0-M9.

@danepitkin
Copy link
Member Author

I'm also not able to reproduce it locally on a different platform (macos). I wonder if it could be that we have an incompatible version matrix configured between the different maven plugins that specifically plagues our CI?

@danepitkin
Copy link
Member Author

danepitkin commented Aug 14, 2024

Actually, I do see this warning from this CI job when trying to reenable multithreading.

Warning:  *****************************************************************
Warning:  * Your build is requesting parallel execution, but this         *
Warning:  * project contains the following plugin(s) that have goals not  *
Warning:  * marked as thread-safe to support parallel execution.          *
Warning:  * While this /may/ work fine, please look for plugin updates    *
Warning:  * and/or request plugins be made thread-safe.                   *
Warning:  * If reporting an issue, report it against the plugin in        *
Warning:  * question, not against Apache Maven.                           *
Warning:  *****************************************************************
Warning:  The following plugins are not marked as thread-safe in Arrow Bill of Materials:
Warning:    org.apache.maven.plugins:maven-site-plugin:3.12.1
Warning:  
Warning:  Enable debug to see precisely which goals are not marked as thread-safe.
Warning:  *****************************************************************

https://github.com/ursacomputing/crossbow/actions/runs/10394740527/job/28785211517

@danepitkin
Copy link
Member Author

According to the Jira ticket (https://issues.apache.org/jira/browse/MSITE-873) this was fixed in 3.20+. We just need to upgrade if we want to use multithreading. The best approach is probably to use a later apache parent pom, which does use a later version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants