Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Add missing PR num to news.md item #43811

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Aug 26, 2024

Rationale for this change

We normally link to somewhere to give the user more context on news items. I noticed the link was missing for this one.

What changes are included in this PR?

Added PR number to news item.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@assignUser assignUser added this to the 18.0.0 milestone Aug 26, 2024
@github-actions github-actions bot removed the awaiting review Awaiting review label Aug 26, 2024
@assignUser assignUser merged commit cbb5f96 into apache:main Aug 26, 2024
11 checks passed
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Aug 26, 2024
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Aug 26, 2024
@amoeba
Copy link
Member Author

amoeba commented Aug 26, 2024

Thanks @assignUser, 🫡 .

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cbb5f96.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 38 possible false positives for unstable benchmarks that are known to sometimes produce them.

mapleFU pushed a commit to mapleFU/arrow that referenced this pull request Sep 3, 2024
### Rationale for this change

We normally link to somewhere to give the user more context on news items. I noticed the link was missing for this one.

### What changes are included in this PR?

Added PR number to news item.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
### Rationale for this change

We normally link to somewhere to give the user more context on news items. I noticed the link was missing for this one.

### What changes are included in this PR?

Added PR number to news item.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants