Skip to content

Conversation

@zeroshade
Copy link
Member

@zeroshade zeroshade commented Sep 5, 2024

Rationale for this change

Widening the Decimal128/256 type to allow for bitwidths of 32 and 64 allows for more interoperability with other libraries and utilities which already support these types. This provides even more opportunities for zero-copy interactions between things such as libcudf and various databases.

What changes are included in this PR?

Updating the documentation in Schema.fbs to explicitly state that 32-bit and 64-bit is now allowed for bitwidths of Decimal types. This is the only area in the the spec that mentions the allowed decimal bitwidths.

@zeroshade zeroshade requested a review from pitrou September 10, 2024 16:16
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Sep 10, 2024
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@zeroshade zeroshade requested a review from pitrou September 10, 2024 19:47
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 10, 2024
@zeroshade zeroshade merged commit c4b68ee into apache:main Sep 10, 2024
@zeroshade zeroshade deleted the expand-decimal-bitwidth-format branch September 10, 2024 19:51
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c4b68ee.

There were 4 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 119 possible false positives for unstable benchmarks that are known to sometimes produce them.

khwilson pushed a commit to khwilson/arrow that referenced this pull request Sep 14, 2024
…43976)

### Rationale for this change
Widening the Decimal128/256 type to allow for bitwidths of 32 and 64
allows for more interoperability with other libraries and utilities
which already support these types. This provides even more opportunities
for zero-copy interactions between things such as libcudf and various
databases.

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

### What changes are included in this PR?
Updating the documentation in Schema.fbs to explicitly state that 32-bit
and 64-bit is now allowed for bitwidths of Decimal types. This is the
only area in the the spec that mentions the allowed decimal bitwidths.
* GitHub Issue: apache#43956

---------

Co-authored-by: Antoine Pitrou <pitrou@free.fr>
kou pushed a commit that referenced this pull request Sep 18, 2024
Fixes a minor docs omission from #43976.

Authored-by: Ian Cook <ianmcook@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants