Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43873: [Go][CI] Remove Go related test CI #44143

Merged
merged 4 commits into from
Sep 19, 2024
Merged

GH-43873: [Go][CI] Remove Go related test CI #44143

merged 4 commits into from
Sep 19, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Sep 17, 2024

Rationale for this change

The Go implementation is moving to apache/arrow-go from go/ in apache/arrow.

What changes are included in this PR?

CI has been migrated to apache/arrow-go repository.

Are these changes tested?

No

Are there any user-facing changes?

No

This comment was marked as outdated.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 17, 2024
@raulcd raulcd changed the title Gh 43873 GH-43873: [Go][CI] Remove Go related test CI Sep 17, 2024
@raulcd
Copy link
Member Author

raulcd commented Sep 17, 2024

This PR should be merged after: #44142 in order to fix the integration error as we don't require the local go_build.sh script anymore after those.

.env Outdated Show resolved Hide resolved
@@ -1866,7 +1801,6 @@ services:
jdk: 17
maven: ${MAVEN}
node: ${NODE}
go: ${GO}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we always use the latest Go in ci/docker/conda-integration.dockerfile?

https://github.com/apache/arrow-go/blob/12482ca3eb1cd4da21c45325e174f1dac871281b/dev/release/verify_rc.sh#L137-L156 may help us.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried something here: 3d2516d

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 18, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Sep 18, 2024
@raulcd raulcd marked this pull request as ready for review September 18, 2024 09:16
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 4013815 into apache:main Sep 19, 2024
44 of 46 checks passed
@kou kou removed the awaiting changes Awaiting changes label Sep 19, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Sep 19, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4013815.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants