-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43519: [Python][CI][Packaging] Use released versions to build and test wheels on Python 3.13 #44193
GH-43519: [Python][CI][Packaging] Use released versions to build and test wheels on Python 3.13 #44193
Conversation
…d and test wheels on Python 3.13
@github-actions crossbow submit -g wheel |
Revision: 7d19a5b Submitted crossbow builds: ursacomputing/crossbow @ actions-91d56dc958 |
I forgot that the free-threading build is of course using the same requirements files, and for those builds we still need cython main (there is not yet a cython release with freethreaded support/wheels). I do think it is important to build are main released wheels with a released version of numpy/cython, so we will have to add the pip flags depending on using a free-threaded python build or not. |
@github-actions crossbow submit wheelcp313t |
Revision: bbe9812 Submitted crossbow builds: ursacomputing/crossbow @ actions-31ac4e075e |
@github-actions crossbow submit wheel-macoscp313t |
Revision: 7a5f484 Submitted crossbow builds: ursacomputing/crossbow @ actions-7e55a83117
|
(the macos arm64 is passing now after restarting it, but so the first time it was failing with a segfault in |
The C++ Async Flight tests also see intermittent crashes on some configurations, I wouldn't necessarily fault PyArrow here. Perhaps the free-threaded build just helps stress threading more in the the Flight tests. |
@github-actions crossbow submit -g wheel |
Revision: ae5fc8f Submitted crossbow builds: ursacomputing/crossbow @ actions-8d08b45b5c |
The mac Python 3.9 build shows those warnings, which might explain the failures (
Now, those warnings also appear in the builds for python >= 3.10, so not entirely sure how to explain the 3.9 failure |
@github-actions crossbow submit wheel-macos-* |
Revision: fa65a63 Submitted crossbow builds: ursacomputing/crossbow @ actions-b3d3ae8e9c |
…nup-requirements
@github-actions crossbow submit -g wheel |
Revision: 6eea81c Submitted crossbow builds: ursacomputing/crossbow @ actions-35278aadcf |
cc @raulcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Could you rebase to fix the CI failures?
…nup-requirements
@github-actions crossbow submit -g wheel |
Revision: 63963fe Submitted crossbow builds: ursacomputing/crossbow @ actions-98e88ff273 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jorisvandenbossche
…test wheels on Python 3.13 (#44193) ### Rationale for this change Now that numpy, cython and pandas all have releases that support Python 3.13, we can remove the extra index and ensure that we are building our wheels with the released version instead of nightly dev version. * GitHub Issue: #43519 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6fe0ff0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Now that numpy, cython and pandas all have releases that support Python 3.13, we can remove the extra index and ensure that we are building our wheels with the released version instead of nightly dev version.