Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs] Refine docs for some compute functions #44305

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

zanmato1984
Copy link
Collaborator

Rationale for this change

Some trivial inaccurate and missing part in compute functions.

What changes are included in this PR?

Refined the inaccurate and missing part.

Are these changes tested?

No need.

Are there any user-facing changes?

None.

@@ -1707,7 +1707,7 @@ These functions select and return a subset of their input.
+---------------+--------+--------------+--------------+--------------+-------------------------+-----------+
| array_take | Binary | Any | Integer | Input type 1 | :struct:`TakeOptions` | \(3) |
+---------------+--------+--------------+--------------+--------------+-------------------------+-----------+
| drop_null | Unary | Any | - | Input type 1 | | \(1) |
| drop_null | Unary | Any | | Input type 1 | | \(1) |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring

| count_all | Nullary | | Scalar Int64 | | |
, use blank for N/A.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 4, 2024
@zanmato1984
Copy link
Collaborator Author

cc @pitrou @kou

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 4, 2024
@kou kou merged commit 7817e3c into apache:main Oct 4, 2024
8 checks passed
@kou kou removed the awaiting merge Awaiting merge label Oct 4, 2024
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7817e3c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants