Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44432: [Swift] Use flatbuffers v24.3.7 #44433

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

kou
Copy link
Member

@kou kou commented Oct 16, 2024

Rationale for this change

flatbuffers v24.3.7 includes google/flatbuffers#8134 .

The current master has a build error:

https://github.com/apache/arrow/actions/runs/11357784776/job/31591213976?pr=44431#step:5:1114

[51/77] Compiling Arrow ArrowType.swift
/arrow/swift/Arrow/Sources/Arrow/File_generated.swift:107:206: error: value of type 'Table' has no member 'postion'
  public var schema: org_apache_arrow_flatbuf_Schema? { let o = _accessor.offset(VTOFFSET.schema.v); return o == 0 ? nil : org_apache_arrow_flatbuf_Schema(_accessor.bb, o: _accessor.indirect(o + _accessor.postion)) }
                                                                                                                                                                                                   ~~~~~~~~~ ^~~~~~~

What changes are included in this PR?

Use v24.3.7 instead of master.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #44432 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-44432: [Swift] Use flatbuffers v24.3.7 or later GH-44432: [Swift] Use flatbuffers v24.3.7 Oct 16, 2024
@kou
Copy link
Member Author

kou commented Oct 16, 2024

@abandy What do you think about this?

@abandy
Copy link
Contributor

abandy commented Oct 16, 2024

@abandy What do you think about this?

Makes sense to pin the version to prevent potential errors from changes in master. Good idea, thank you!

@kou
Copy link
Member Author

kou commented Oct 16, 2024

Thanks for your review.
I'll merge this.

@kou kou merged commit bb900c1 into apache:main Oct 16, 2024
8 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Oct 16, 2024
@kou kou deleted the swift-flatbuffers branch October 16, 2024 12:06
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bb900c1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants