-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Dev][Release] Stop post-04-website.sh script if archery isn't available #44823
Conversation
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Thanks @kou. I pulled your latest suggestions, tested locally, and it's working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 050fb80. There were 132 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The release script at
dev/release/post-04-website.sh
doesn't quite work right if archery isn't available. The PR gets made but the changelog isn't included. See when this happened during the 18.0.0 release: apache/arrow-site#551 (comment).What changes are included in this PR?
Before the script does anything meaningful, it checks for archery and stops if it's not available.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.