Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Dev][Release] Stop post-04-website.sh script if archery isn't available #44823

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Nov 24, 2024

Rationale for this change

The release script at dev/release/post-04-website.sh doesn't quite work right if archery isn't available. The PR gets made but the changelog isn't included. See when this happened during the 18.0.0 release: apache/arrow-site#551 (comment).

What changes are included in this PR?

Before the script does anything meaningful, it checks for archery and stops if it's not available.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

dev/release/post-04-website.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Nov 25, 2024
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 25, 2024
dev/release/post-04-website.sh Outdated Show resolved Hide resolved
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Nov 25, 2024
@amoeba
Copy link
Member Author

amoeba commented Nov 25, 2024

Thanks @kou. I pulled your latest suggestions, tested locally, and it's working fine.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 050fb80 into apache:main Nov 25, 2024
7 checks passed
@kou kou removed the awaiting change review Awaiting change review label Nov 25, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 25, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 050fb80.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants