GH-45398: [CI][Dev][Ruby] Add Ruby lint

[hiroyuki-sato]

Rationale for this change

Multiple users are developing Ruby codes. Adding Ruby Lint helps keep the same style.

What changes are included in this PR?

Add Ruby Lint. (Rubocop)

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev][Ruby] Add Ruby lint #45398

[github-actions]

⚠️ GitHub issue #45398 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

This PR relates to Ruby. @kou Please check this too.

[kou]

Do we need this?

[hiroyuki-sato]

Without this part and if the line width is 90, the pre-check claims the following
As we discussed on this #45403 (comment),
we need to exclude homebrew formulae. So, I added this part.

diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb b/dev/tasks/homebrew-formulae/apache-arrow.rb
index caf82b8db..01611d17b 100644
--- a/dev/tasks/homebrew-formulae/apache-arrow.rb
+++ b/dev/tasks/homebrew-formulae/apache-arrow.rb
@@ -110,7 +110,8 @@ class ApacheArrow < Formula
         return 0;
       }
     EOS
-    system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}", "-larrow", "-o", "test"
+    system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}", "-larrow",
+           "-o", "test"
     system "./test"
   end
 end

[kou]

dev/tasks/homebrew-formulae/*.rb should be excluded by exclude not files.

[hiroyuki-sato]

I'm not familiar pre-commit configuration. I thought you commented exclude part. But you commented about the files part? If so, It seems OK to delete that part.

Do you mean this?

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 8dcbeaece..cc46728b0 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -152,7 +152,6 @@ repos:
           (
           ?^dev/tasks/homebrew-formulae/.*\.rb$|
           )
-        files: .*\.rb$
   - repo: https://github.com/cheshirekow/cmake-format-precommit
     rev: v0.6.13
     hooks:

[hiroyuki-sato]

Removed files part. It seems to work well.

pre-commit run --verbose --all-files --color=always --show-diff-on-failure ruby-format
Ruby Format..............................................................Passed
- hook id: rubocop
- duration: 1.66s

Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 84 files
....................................................................................

84 files inspected, no offenses detected
Inspecting 77 files
.............................................................................

77 files inspected, no offenses detected

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6305c6e.

There were 8 benchmark results with an error:

• Commit Run on arm64-t4g-2xlarge-linux at 2025-02-03 09:30:28Z
  • tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=1
• and 6 more (see the report linked below)

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.