GH-46395: [C++][Statistics] Use EqualOptions for min and max in arrow::ArrayStatistics::Equals() #46422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kou what is your view on |
kou
changed the title
Member
|
It may be better that we add Could you start a discussion for this like #46396 ? |
Contributor
Author
|
I will open an issue for discussion soon |
andishgar
force-pushed
the
correct-statistics-equal-method
branch
from
afb535b to
663b645
Compare
Contributor
Author
|
@kou |
kou
reviewed
May 31, 2025
github-actions
bot
added
awaiting changes
Contributor
Author
|
Thank you for your feedback, @kou — I'll look into it |
andishgar
force-pushed
the
correct-statistics-equal-method
branch
from
3dbecf1 to
a362b94
Compare
github-actions
bot
added
awaiting change review
andishgar
force-pushed
the
correct-statistics-equal-method
branch
from
a362b94 to
1d6812d
Compare
kou
reviewed
Jun 2, 2025
github-actions
bot
added
awaiting changes
Contributor
Author
|
Thank you for your feedback, @kou — I'll look into it |
kou
reviewed
Jun 5, 2025
Contributor
Author
|
@kou I apologize for my last commit — it seems I forgot to apply some of the notes you mentioned. |
andishgar
force-pushed
the
correct-statistics-equal-method
branch
from
3ff6117 to
d661877
Compare
github-actions
bot
added
awaiting change review
replace allow_atol to use_atol with relevant changes move type alias declaration for ValueType into anonymous namesapce comment == and != for operator and remove default options clear comments test and comment regarding different ValueType breakdown TestEqualityDoubleValues test case into several test cases
andishgar
force-pushed
the
correct-statistics-equal-method
branch
from
d661877 to
e06599f
Compare
kou
changed the title
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0e5249b. There were 72 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
alinaliBQ
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
… arrow::ArrayStatistics::Equals() (apache#46422) ### Rationale for this change `arrow::ArrayStatistics::Equals` does not handle double values for `ArrayStatistics::ValueType` correctly ### What changes are included in this PR? Add `arrow::EqualOptions` to `arrow::ArrayStatistics::Eqauls()` Add `arrow::ArrayStatisticsEqauls()` Add `EqualOptions::use_atol_` Add `EqualOptions::use_atol()` Add `EqualOptions::use_atol(bool v)` ### Are these changes tested? Yes, I ran the relevant unit tests. ### Are there any user-facing changes? Yes. Add `arrow::ArrayStatisticsEqauls()` Add `EqualOptions::use_atol()` Add `EqualOptions::use_atol(bool v)` * GitHub Issue: apache#46395 Authored-by: Arash Andishgar <arashandishgar1@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow::ArrayStatistics::Equalsdoes not handle double values forArrayStatistics::ValueTypecorrectlyWhat changes are included in this PR?
Add
arrow::EqualOptionstoarrow::ArrayStatistics::Eqauls()Add
arrow::ArrayStatisticsEqauls()Add
EqualOptions::use_atol_Add
EqualOptions::use_atol()Add
EqualOptions::use_atol(bool v)Are these changes tested?
Yes, I ran the relevant unit tests.
Are there any user-facing changes?
Yes.
Add
arrow::ArrayStatisticsEqauls()Add
EqualOptions::use_atol()Add
EqualOptions::use_atol(bool v)