Skip to content

GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 7 commits into from
Jun 10, 2025
+27 −26
Merged

GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b581a64
GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_bui…
hiroyuki-sato Jun 6, 2025
123f691
Update ci/scripts/conan_build.sh
hiroyuki-sato Jun 6, 2025
16999da
GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_bui…
hiroyuki-sato Jun 10, 2025
b894aef
Revert "GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/c…
hiroyuki-sato Jun 7, 2025
62c6767
Reapply "GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/…
hiroyuki-sato Jun 7, 2025
ab05c5c
Fix merge conflict
hiroyuki-sato Jun 10, 2025
c87a7f6
GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_bui…
hiroyuki-sato Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ repos:
?^c_glib/test/run-test\.sh$|
?^ci/scripts/c_glib_build\.sh$|
?^ci/scripts/c_glib_test\.sh$|
?^ci/scripts/conan_build\.sh$|
?^ci/scripts/conan_setup\.sh$|
?^ci/scripts/cpp_test\.sh$|
?^ci/scripts/csharp_build\.sh$|
Expand Down
52 changes: 26 additions & 26 deletions ci/scripts/conan_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,56 +29,56 @@ export ARROW_HOME=${source_dir}
conan_args=()
conan_args+=(--build=missing)
if [ -n "${ARROW_CONAN_PARQUET:-}" ]; then
conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_PARQUET})
conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")
conan_args+=(--options "arrow/*:with_boost=${ARROW_CONAN_PARQUET}")
conan_args+=(--options "arrow/*:with_json=${ARROW_CONAN_PARQUET}")
conan_args+=(--options "arrow/*:with_thrift=${ARROW_CONAN_PARQUET}")
else
conan_args+=(--options arrow/*:parquet=False)
conan_args+=(--options "arrow/*:parquet=False")
fi
if [ -n "${ARROW_CONAN_WITH_BROTLI:-}" ]; then
conan_args+=(--options arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI})
conan_args+=(--options "arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI}")
fi
if [ -n "${ARROW_CONAN_WITH_BZ2:-}" ]; then
conan_args+=(--options arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2})
conan_args+=(--options "arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2}")
fi
if [ -n "${ARROW_CONAN_WITH_FLIGHT_RPC:-}" ]; then
conan_args+=(--options arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
conan_args+=(--options arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
conan_args+=(--options arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC})
conan_args+=(--options arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC})
conan_args+=(--options "arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC}")
conan_args+=(--options "arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC}")
conan_args+=(--options "arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC}")
conan_args+=(--options "arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC}")
fi
if [ -n "${ARROW_CONAN_WITH_GLOG:-}" ]; then
conan_args+=(--options arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG})
conan_args+=(--options "arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG}")
fi
if [ -n "${ARROW_CONAN_WITH_JEMALLOC:-}" ]; then
conan_args+=(--options arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC})
conan_args+=(--options "arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC}")
fi
if [ -n "${ARROW_CONAN_WITH_JSON:-}" ]; then
conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_WITH_JSON})
conan_args+=(--options "arrow/*:with_json=${ARROW_CONAN_WITH_JSON}")
fi
if [ -n "${ARROW_CONAN_WITH_LZ4:-}" ]; then
conan_args+=(--options arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4})
conan_args+=(--options "arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4}")
fi
if [ -n "${ARROW_CONAN_WITH_SNAPPY:-}" ]; then
conan_args+=(--options arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY})
conan_args+=(--options "arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY}")
fi
if [ -n "${ARROW_CONAN_WITH_ZSTD:-}" ]; then
conan_args+=(--options arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD})
conan_args+=(--options "arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD}")
fi

version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \
version=$(grep '^set(ARROW_VERSION ' "${ARROW_HOME}/cpp/CMakeLists.txt" | \
grep -E -o '([0-9.]*)')
conan_args+=(--version ${version})
conan_args+=(--version "${version}")

rm -rf ~/.conan/data/arrow/
rm -rf ${build_dir}/conan || sudo rm -rf ${build_dir}/conan
mkdir -p ${build_dir}/conan || sudo mkdir -p ${build_dir}/conan
if [ -w ${build_dir} ]; then
cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
rm -rf "${build_dir}/conan" || sudo rm -rf "${build_dir}/conan"
mkdir -p "${build_dir}/conan" || sudo mkdir -p "${build_dir}/conan"
if [ -w "${build_dir}" ]; then
cp -a "${source_dir}"/ci/conan/* "${build_dir}/conan/"
else
sudo cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
sudo chown -R $(id -u):$(id -g) ${build_dir}/conan/
sudo cp -a "${source_dir}"/ci/conan/* "${build_dir}/conan/"
sudo chown -R "$(id -u):$(id -g)" "${build_dir}/conan/"
fi
cd ${build_dir}/conan/all
cd "${build_dir}/conan/all"
conan create . "${conan_args[@]}" "$@"
Loading