GH-47614: [CI] Upgrade vcpkg on our CI #47627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@github-actions crossbow submit wheel-manylinux-2-28-cp310-cp310-amd64 |
|
Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4 Submitted crossbow builds: ursacomputing/crossbow @ actions-60c2e12547
|
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 wheel-musllinux-1-2-cp312-cp312-arm64 wheel-macos-monterey-cp312-cp312-amd64 |
|
Revision: f6fea6f2ace1caf680dea98c367ca6f9c9f97af4 Submitted crossbow builds: ursacomputing/crossbow @ actions-63c80eedf6
|
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Member
Author
|
@github-actions crossbow submit wheel-musllinux-1-2-cp312-cp312-arm64 |
|
Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72 Submitted crossbow builds: ursacomputing/crossbow @ actions-75b62cd59e
|
|
Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72 Submitted crossbow builds: ursacomputing/crossbow @ actions-557ed877e6
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@github-actions crossbow submit wheel-windows-* |
|
Revision: 0f5fcdb7c98660fef4514af0a048cf4a976efc72 Submitted crossbow builds: ursacomputing/crossbow @ actions-ad950fd0f7
|
Member
Author
|
There are two Python test failures on the musllinux wheel related to ORC timezone but there's no @wgtmac @kou any idea? |
Member
|
I think there is an upstream change from IANA TZDB and might be fixed in a way similar to https://github.com/apache/orc/pull/2363/files#diff-6c9de59647d8013be967b7259ce33ba22923a7c340383bbf9a55ec1aa4d03c03R419-R427 |
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
Revision: c7fa2b963b212ac99c4661a741903ebd9480b4ce Submitted crossbow builds: ursacomputing/crossbow @ actions-67f7bf6a17
|
Member
Author
@wgtmac I've been investigating a little further the issue is with a couple tests that are "intentionally" removing the timezone and expecting ORC to raise an exception and Arrow to catch it but not to crash, the problem (on this specific case) is with ORC 2.1.0 which is the one on vcpkg and musllinux. See the backtrace: terminate called after throwing an instance of 'orc::TimezoneError'
what(): Time zone file /tmp/non_existent/US/Pacific does not exist. Please install IANA time zone database and set TZDIR env.
Thread 1 "python" received signal SIGABRT, Aborted.
__restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
warning: 40 ./arch/x86_64/syscall_arch.h: No such file or directory
(gdb) backtrace
#0 __restore_sigs (set=set@entry=0x7ffc7ba108e0) at ./arch/x86_64/syscall_arch.h:40
#1 0x000076f54c58fe1b in raise (sig=sig@entry=6) at src/signal/raise.c:11
#2 0x000076f54c5739ad in abort () at src/exit/abort.c:11
#3 0x000076f5484f2a4a in ?? () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#4 0x000076f548504ef8 in __cxxabiv1::__terminate(void (*)()) () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#5 0x000076f548504f65 in std::terminate() () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#6 0x000076f5485051b8 in __cxa_throw () from /usr/local/lib/python3.10/site-packages/pyarrow/../pyarrow.libs/libstdc++-0d31ccbe.so.6.0.32
#7 0x000076f54a04b1ee in orc::loadTZDB(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#8 0x000076f54a04b9f3 in std::once_flag::_Prepare_execution::_Prepare_execution<std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#1}>(orc::LazyTimezone::getImpl() const::{lambda()#1}&)::{lambda()#1}::_FUN() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#9 0x000076f54c599656 in __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:22
#10 __pthread_once_full (control=0x76f546a4b1b0, init=0x76f548532c70 <__once_proxy>) at src/thread/pthread_once.c:11
#11 0x000076f54c5996f3 in __pthread_once (control=<optimized out>, init=<optimized out>) at src/thread/pthread_once.c:47
#12 0x000076f54a049659 in orc::LazyTimezone::getEpoch() const () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#13 0x000076f54a0804cf in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#14 0x000076f54a08155d in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#15 0x000076f54a081c36 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#16 0x000076f54a0815e3 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#17 0x000076f54a02f60d in orc::RowReaderImpl::startNextStripe() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#18 0x000076f54a030005 in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#19 0x000076f5495206a5 in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#20 0x000076f549520d6a in arrow::adapters::orc::ORCFileReader::Impl::ReadTable(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&) ()
from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#21 0x000076f54951a3d7 in arrow::adapters::orc::ORCFileReader::Read() () from /usr/local/lib/python3.10/site-packages/pyarrow/libarrow.so.2200
#22 0x000076f525a6c55c in __pyx_pw_7pyarrow_4_orc_9ORCReader_43read(_object*, _object* const*, long, _object*) ()@pitrou based on the stacktrace and the report this seems to be the exact same issue fixed that introduced the failing tests, any idea? |
Member
Author
|
The Windows failures are completely different and are due to a flight compilation error, I am trying to understand what is the problem too: We should try to push the vcpkg version update because we have been using a really old one and updating it fixes the macOS wheels. |
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
Revision: b73a6f75ac91e3ef3475c274855cf69a1a57df57 Submitted crossbow builds: ursacomputing/crossbow @ actions-01928a4f01
|
Member
|
@raulcd Did you check that |
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
Revision: 51110d116e4fc4cb0d962e8f012e3177748e828e Submitted crossbow builds: ursacomputing/crossbow @ actions-f5546167b3
|
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
Revision: 41ba405 Submitted crossbow builds: ursacomputing/crossbow @ actions-05962c1816
|
… python_wheel_unix_test.sh
Member
Author
|
@github-actions crossbow submit wheel-macos-monterey-cp313-*-amd64 |
|
Revision: b02bc4f Submitted crossbow builds: ursacomputing/crossbow @ actions-b64128ce9f
|
…es from header files
Member
Author
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
Revision: 09c6acd Submitted crossbow builds: ursacomputing/crossbow @ actions-1b5b55ee21
|
github-actions
bot
added
awaiting changes
Member
Author
|
@github-actions crossbow submit -g wheel |
|
Revision: 09c6acd Submitted crossbow builds: ursacomputing/crossbow @ actions-896442bc8b
|
github-actions
bot
added
awaiting merge
Member
|
+1 from me after a quick look, thanks a lot!
Le 2 octobre 2025 13:26:28 GMT+02:00, "Raúl Cumplido" ***@***.***> a écrit :
…
@raulcd requested your review on: apache/arrow#47627 GH-47614: [CI] Upgrade vcpkg on our CI.
--
Reply to this email directly or view it on GitHub:
#47627 (comment)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cde3f6a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
### Rationale for this change Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions. ### What changes are included in this PR? - Update the vcpkg version to the latest released - Update minio version to solve failure due to newer aws-sdk - Remove unnecessary vcpkg patches - Add patch to ORC vcpkg to solve issue with exception not being propagated on std::run_once on musllinux. - Avoid adding some flight sources on Windows unity builds that cause windows headers clashing. ### Are these changes tested? Yes, via archery on CI. ### Are there any user-facing changes? No * GitHub Issue: apache#43416 * GitHub Issue: apache#47614 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our vcpkg version used for the wheels is a really old version. Some wheels like the macOS ones have started failing due to really old dependencies using unsupported cake versions.
What changes are included in this PR?
Are these changes tested?
Yes, via archery on CI.
Are there any user-facing changes?
No