Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5848: [C++] SO versioning schema after release 1.0.0 #4801

Closed
wants to merge 3 commits into from
Closed

ARROW-5848: [C++] SO versioning schema after release 1.0.0 #4801

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
431ef56
update SO versioning
kszucs Jul 4, 2019
74a8cbf
fix full so-version in comment
kszucs Jul 4, 2019
81519fe
cmake-format
kszucs Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,14 @@ if(ARROW_VERSION_MAJOR STREQUAL ""
endif()

# The SO version is also the ABI version
if(arrow_VERSION_MAJOR STREQUAL "0")
if(ARROW_VERSION_MAJOR STREQUAL "0")
# Arrow 0.x.y => SO version is "x", full SO version is "x.y.0"
set(ARROW_SO_VERSION "${ARROW_VERSION_MINOR}")
set(ARROW_FULL_SO_VERSION "${ARROW_SO_VERSION}.${ARROW_VERSION_PATCH}.0")
else()
message(FATAL_ERROR "Need to implement SO version generation for Arrow 1.0+")
# Arrow 1.x.y => SO version is "10x", full SO version is "10x.y.0"
math(EXPR ARROW_SO_VERSION "${ARROW_VERSION_MAJOR} * 100 + ${ARROW_VERSION_MINOR}")
set(ARROW_FULL_SO_VERSION "${ARROW_SO_VERSION}.${ARROW_VERSION_PATCH}.0")
endif()

message(STATUS "Arrow version: "
Expand Down