GH-47961: [C++] Fix Meson's Boost process version detection #48017
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillAyd
force-pushed
the
meson-fix-boost
branch
2 times, most recently
from
6ce5075 to
537e0ae
Compare
|
Hi @kou - this is ready for review. Do you mind taking a look when you can? Thanks! |
kou
approved these changes
Nov 4, 2025
cpp/src/arrow/meson.build
Outdated
Comment on lines
687
to
690
| filesystem_dep, | ||
| gmock_dep, | ||
| gtest_dep, | ||
| process_dep, |
There was a problem hiding this comment.
Could you use the following order because Boost.Process depends on Boost.Filesystem:
Suggested change
| filesystem_dep, | |
| gmock_dep, | |
| gtest_dep, | |
| process_dep, | |
| process_dep, | |
| filesystem_dep, | |
| gmock_dep, | |
| gtest_dep, |
github-actions
bot
added
awaiting merge
WillAyd
force-pushed
the
meson-fix-boost
branch
from
537e0ae to
59ea770
Compare
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit d9c1881. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Meson is missing some defines that offer compatibility for different boost versions
What changes are included in this PR?
The Meson configuration is updated to include required boost defines
Are these changes tested?
Yes
Are there any user-facing changes?
No