-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47371, GH-48281: [Python][CI] Fix Numba-CUDA interop #48284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The extra that specifies the CUDA version for Numba_CUDA is required for the CUDA Python bindings to be installed as a Numba-CUDA dependency. This commit adds the appropriate extra to the Numba-CUDA installation, so that the bindings will be installed in the CI environment. This should allow the Numba-CUDA interop tests to run in CI again, instead of getting skipped.
- Numba-CUDA 0.21.2 has been released, which fixes the API breakage that affected Numba-CUDA interop tests. - The previous commit fixes the installation of Numba-CUDA in the CI environment. - This commit removes the skip of the Numba-CUDA interop tests, with the aim of them running again and passing.
|
@github-actions crossbow submit cuda |
|
Revision: 91662d1 Submitted crossbow builds: ursacomputing/crossbow @ actions-487d05af51
|
|
For the CUDA 11 tests, from https://github.com/ursacomputing/crossbow/actions/runs/19770191970/job/56652474566#step:6:289: current Numba-CUDA versions only support CUDA 12 and 13, so this is not unexpected. For the CUDA 13 tests, it looks to me as if the required packages have installed and the tests ran: and I don't see it being skipped. |
Ok. Well, since CI is green, and the CUDA tests pass anyway, I think this is not a problem. |
Rationale for this change
The extra that specifies the CUDA version for Numba-CUDA is required for the CUDA Python bindings to be installed as a Numba-CUDA dependency. Presently the Numba-CUDA interop tests are skipped, and it would be preferable to enable them again and ensure the test suite doesn't skip them due to lack of dependencies.
What changes are included in this PR?
Are these changes tested?
Yes (assuming the CI setup works correctly again with these changes)
Are there any user-facing changes?
No.