GH-44810: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #48285
+115
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
kou
reviewed
Nov 28, 2025
github-actions
bot
added
awaiting changes
…arrow::FileReader::Make()
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
hiroyuki-sato
force-pushed
the
topic/parquet-result-reader
branch
from
86eba06 to
7ef530c
Compare
github-actions
bot
added
awaiting change review
hiroyuki-sato
commented
Dec 1, 2025
Collaborator
Author
hiroyuki-sato
left a comment
hiroyuki-sato
left a comment
There was a problem hiding this comment.
@kou CI passed Please take a look when you get a chacne.
| std::unique_ptr<FileReader> arrow_reader; | ||
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | ||
| &arrow_reader)); | ||
| auto reader_result = |
Collaborator
Author
There was a problem hiding this comment.
Can we use ASSERT_OK_AND_ASSIGN here?
Member
There was a problem hiding this comment.
No. ASSERT_OK_AND_ASSIGN() is for Google Test. Benchmarks uses Google Benchmark not Google Test.
kou
reviewed
Dec 1, 2025
Comment on lines
299
to
+302
| std::unique_ptr<FileReader> arrow_reader; | ||
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | ||
| &arrow_reader)); | ||
| auto reader_result = | ||
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | ||
| EXIT_NOT_OK(reader_result.status()); |
Member
There was a problem hiding this comment.
We need to assign to arrow_reader:
Suggested change
| std::unique_ptr<FileReader> arrow_reader; | |
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | |
| &arrow_reader)); | |
| auto reader_result = | |
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | |
| EXIT_NOT_OK(reader_result.status()); | |
| auto arrow_reader_result = | |
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | |
| EXIT_NOT_OK(arrow_reader_result.status()); | |
| auto arrow_reader = *arrow_reader_result; |
| std::unique_ptr<FileReader> arrow_reader; | ||
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | ||
| &arrow_reader)); | ||
| auto reader_result = |
Member
There was a problem hiding this comment.
No. ASSERT_OK_AND_ASSIGN() is for Google Test. Benchmarks uses Google Benchmark not Google Test.
Comment on lines
739
to
+742
| std::unique_ptr<FileReader> arrow_reader; | ||
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | ||
| &arrow_reader)); | ||
| auto reader_result = | ||
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | ||
| EXIT_NOT_OK(reader_result.status()); |
Member
There was a problem hiding this comment.
Suggested change
| std::unique_ptr<FileReader> arrow_reader; | |
| EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(), std::move(reader), | |
| &arrow_reader)); | |
| auto reader_result = | |
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | |
| EXIT_NOT_OK(reader_result.status()); | |
| auto arrow_reader_result = | |
| FileReader::Make(::arrow::default_memory_pool(), std::move(reader)); | |
| EXIT_NOT_OK(reader_result.status()); | |
| auto arrow_reader = *arrow_reader_result; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FileReader::Makepreviously returnedStatusand required callers to pass anoutparameter.What changes are included in this PR?
Introduce a
Result<std::unique_ptr<FileReader>>returning API to allow clearer error propagationAre these changes tested?
Yes.
Are there any user-facing changes?
No.
arrow::Resultversion ofparquet::arrow::FileReader::Make()#44810