GH-48594: [C++][FlightRPC] Fix ODBC CI Long Build Time Issue #48595

alinaliBQ · 2025-12-18T18:58:10Z

Rationale for this change

#48594

What changes are included in this PR?

Resolve caching issue inside ODBC CI, so build time is generally less than 1hr
Removed environment variables that are not necessary for ODBC building to keep workflow simple
Changed ODBC workflow to be triggered when ODBC files are changed
Add CI: Extra: C++ label when ODBC files pr C++ Extra workflow is changed

Are these changes tested?

Tested in CI

Are there any user-facing changes?

N/A

GitHub Issue: [C++][FlightSQL][ODBC] MSVC CI caching issues #48594

github-actions · 2025-12-18T18:58:38Z

⚠️ GitHub issue #48594 has been automatically assigned in GitHub to PR creator.

alinaliBQ · 2025-12-19T00:09:05Z

Hi @pitrou and @raulcd, to follow up on #48313 I have opened this draft PR.

As Raul has pointed out in #48313 (comment), there is an issue pushing the packages to nuget. Therefore, when a new ODBC build begins, all vcpkg packages are rebuilt and that is the root cause of the long ODBC build time.

Does it require any changes in the GitHub repository settings to allow the new workflow to push packages to https://nuget.pkg.github.com/apache?

alinaliBQ · 2025-12-19T00:09:18Z

During investigation, I tried running vcpkg install command before the cpp_build.sh script in C GLib & Ruby MSVC workflow, and it has the same 403 error as ODBC MSVC. But the script cpp_build.sh in GLib workflow can still publish nuget packages normally. I am not sure why the same script works in GLib MSVC, but not in ODBC MSVC.
Run log: https://github.com/apache/arrow/actions/runs/20353354024/job/58483242851?pr=48595#step:13:3353

alinaliBQ · 2025-12-20T01:45:49Z

ODBC build time has been reduced to around 40 - 60 mins. PR is ready for review. Raised an issue for the flakey 403 request error #48604. Raised #48606 for nuget push timeout issue.

kou · 2026-01-07T01:34:47Z

.github/workflows/cpp_extra.yml

      contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') ||
-      contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++')
+      contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') ||
+      contains(join(github.event.pull_request.changed_files, ' '), 'cpp/src/arrow/flight/sql/odbc/')


You want to run this job even if we don't have CI: Extra labels, right?

Yes, it will be easier to run this job automatically. Is this approach alright?

I don't think that's the right approach, as ODBC can still be affected by non-ODBC changes. We don't do this for other optional jobs such as CUDA, etc.

I agree that ODBC can be effected by non-ODBC changes, and I have removed this approach.
Is there a way for non-admin users to trigger the CI: Extra jobs? If I have access to add the CI extra labels, I don't mind adding the labels for ODBC PRs to run the ODBC workflows

Can we use https://github.com/apache/arrow/blob/main/.github/workflows/dev_pr/labeler.yml ?

Thanks Kou for pointing me there. Will take a look.
I have been given Triage access this morning, I believe now I have access to add the CI: Extra labels.

@kou I have added a section to add CI: Extra in labeler.yml. However it is not adding new labels.
From my testing in my fork repo, I found that the GitHub Actions only picks up on the labeler.yml from the target branch, and not from the head branch. I found even when I comment out contents from labeler.yml (in head branch), new labels are still being added.

I think that the default branch's labelar.yml is only used.

Could you update the PR description?

Ok that makes sense. I have updated the PR description

Attempt to resolve caching issue with ODBC CI Apply Kou's suggestion for nuget timeout Add write permission to store vcpkg cache Check nuget paths in Ruby Glib and ODBC Run vcpkg install after vcpkg is set in GLib Enable vcpkg verbose in GLib * confirmed `vcpkg install` command returns 403 error Add ARROW_HOME Remove `ARROW_SIMD_LEVEL` as it is not required for ODBC. Remove debug msgs Cannot get vcpkg in cpp_build to show debug messages Move location of `packages: write` Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off` Revert "Move location of `packages: write`" This reverts commit b62e04e. Revert "Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off`" This reverts commit 5fdf425. Add GLib MSVC build to C++ Extra TEMP disable ODBC build Disable cmake and enable build Re-enable cmake 4.1.2 and use install_vcpkg.sh to install vcpkg

Cannot add ODBC Label because it requires write access

kou

+1

conbench-apache-arrow · 2026-01-13T07:33:24Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit cb100b2.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

github-actions bot added the awaiting review Awaiting review label Dec 18, 2025

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch 7 times, most recently from 6efa7d4 to c32f221 Compare December 18, 2025 23:32

github-actions bot added the Component: C++ label Dec 18, 2025

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 4b78fb7 to d0bd9f6 Compare December 19, 2025 00:06

github-actions bot removed the Component: C++ label Dec 19, 2025

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch 9 times, most recently from 0e31acb to 0c911a5 Compare December 20, 2025 00:14

alinaliBQ changed the title ~~GH-48594: [C++][FlightRPC] Fix ODBC CI Caching Issue~~ GH-48594: [C++][FlightRPC] Fix ODBC CI Nuget Package Upload Issue Dec 20, 2025

alinaliBQ changed the title ~~GH-48594: [C++][FlightRPC] Fix ODBC CI Nuget Package Upload Issue~~ GH-48594: [C++][FlightRPC] Fix ODBC CI Long Build Time Issue Dec 20, 2025

alinaliBQ marked this pull request as ready for review December 20, 2025 01:45

alinaliBQ requested review from assignUser, jonkeane and kou as code owners December 20, 2025 01:45

github-actions bot added the awaiting committer review Awaiting committer review label Jan 6, 2026

kou reviewed Jan 7, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Jan 7, 2026

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch 2 times, most recently from 5c91082 to dc636af Compare January 8, 2026 22:05

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from dc636af to e6223ef Compare January 8, 2026 22:07

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 9, 2026

alinaliBQ added the CI: Extra: C++ Run extra C++ CI label Jan 9, 2026

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 9, 2026

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 4ef1276 to 1c5f256 Compare January 9, 2026 23:32

alinaliBQ removed the CI: Extra: C++ Run extra C++ CI label Jan 9, 2026

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 1c5f256 to 06dc93f Compare January 9, 2026 23:35

Use Labeler to automatically add C++ Extra label

519da21

Cannot add ODBC Label because it requires write access

alinaliBQ force-pushed the gh-48594-fix-msvc-ci branch from 06dc93f to 519da21 Compare January 9, 2026 23:37

alinaliBQ closed this Jan 9, 2026

alinaliBQ reopened this Jan 9, 2026

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 10, 2026

kou approved these changes Jan 13, 2026

View reviewed changes

kou merged commit cb100b2 into apache:main Jan 13, 2026
23 of 33 checks passed

kou removed the awaiting changes Awaiting changes label Jan 13, 2026

kou mentioned this pull request Jan 13, 2026

[C++][FlightSQL][ODBC] MSVC CI caching issues #48594

Closed

github-actions bot added the awaiting merge Awaiting merge label Jan 13, 2026

GH-48594: [C++][FlightRPC] Fix ODBC CI Long Build Time Issue #48595

GH-48594: [C++][FlightRPC] Fix ODBC CI Long Build Time Issue #48595

Conversation

alinaliBQ commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

alinaliBQ commented Dec 19, 2025

Uh oh!

alinaliBQ commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alinaliBQ commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alinaliBQ commented Dec 18, 2025 •

edited

Loading

alinaliBQ commented Dec 19, 2025 •

edited

Loading

alinaliBQ commented Dec 20, 2025 •

edited

Loading

alinaliBQ Jan 10, 2026 •

edited

Loading