Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-7863: [C++][Python][CI] Ensure running HDFS related tests #6432

Closed
wants to merge 3 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Feb 15, 2020

libhdfs3 backend may be broken. It causes SEGV. So libhdfs3 backend
test is disabled for now.

libhdfs3 backend may be broken. It causes SEGV. So libhdfs3 backend
test is disabled for now.
@kou
Copy link
Member Author

kou commented Feb 15, 2020

@ursabot crossbow submit test-conda-python-3.7-hdfs-2.9.2

@ursabot
Copy link

ursabot commented Feb 15, 2020

AMD64 Conda Crossbow Submit (#90851) builder has been succeeded.

Revision: b54664c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-509

Task Status
test-conda-python-3.7-hdfs-2.9.2 CircleCI

@github-actions
Copy link

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xhochy

.env Outdated
@@ -35,6 +35,7 @@ PANDAS=latest
DASK=latest
TURBODBC=latest
HDFS=2.9.2
LIBHDFS3=2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libhdfs3 2.3 is not supported at all. Version 2.2.31 is the last one we support but I'm not sure if that still works with the current set of conda-forge dependencies / compilers. We might propose reverting the feedstock to the last "good" version that uses the libhdfs C ABI

conda-forge/libhdfs3-feedstock@97fd932#diff-ae18fe4e01e61a9862ceaf165003213a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can build that for you when you provide me with a source tarball at a semi-official location. The original one seems to be vanished.

@wesm
Copy link
Member

wesm commented Feb 17, 2020

Also to be honest I would be OK with removing support for libhdfs3 altogether since it is abandonware

function use_libhdfs_dir() {
unset HADOOP_HOME
export ARROW_LIBHDFS_DIR=$libhdfs_dir
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou Could you explain the difference between the two? (use_hadoop_home vs. use_libhdfs_dir)
Are there two sources for libhdfs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find ${HADOOP_HOME}/lib/native/libhdfs.so when user uses HADOOP_HOME.
We need to find ${ARROW_LIBHDFS_DIR}/libhdfs.so when user uses ARROW_LIBHDFS_DIR.

If HADOOP_HOME is defined, ARROW_LIBHDFS_DIR isn't used. So we need to test them separately.

@kou
Copy link
Member Author

kou commented Feb 18, 2020

OK. I'll remove libhdfs3 support.

@kszucs
Copy link
Member

kszucs commented Feb 18, 2020

We used to test libhdfs3 support until conda forge provided the right version, but in the last iteration I've removed it.

@kou
Copy link
Member Author

kou commented Feb 18, 2020

@ursabot crossbow submit test-conda-python-3.7-hdfs-2.9.2

@ursabot
Copy link

ursabot commented Feb 18, 2020

AMD64 Conda Crossbow Submit (#91370) builder has been succeeded.

Revision: 9620d03

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-515

Task Status
test-conda-python-3.7-hdfs-2.9.2 CircleCI

It's no longer maintained.
@kou kou force-pushed the cpp-hdfs-test-robust branch from 9620d03 to b311877 Compare February 18, 2020 21:03
@kou
Copy link
Member Author

kou commented Feb 18, 2020

@ursabot crossbow submit test-conda-python-3.7-hdfs-2.9.2

@ursabot
Copy link

ursabot commented Feb 18, 2020

AMD64 Conda Crossbow Submit (#91379) builder has been succeeded.

Revision: b311877

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-516

Task Status
test-conda-python-3.7-hdfs-2.9.2 CircleCI

@kou
Copy link
Member Author

kou commented Feb 19, 2020

@ursabot crossbow submit test-conda-python-3.7-hdfs-2.9.2

@ursabot
Copy link

ursabot commented Feb 19, 2020

AMD64 Conda Crossbow Submit (#91421) builder has been succeeded.

Revision: 85b45ad

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-518

Task Status
test-conda-python-3.7-hdfs-2.9.2 CircleCI

@kou
Copy link
Member Author

kou commented Feb 19, 2020

Done.

@kou
Copy link
Member Author

kou commented Feb 20, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants