Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-977: [java] Add Timezone aware timestamp vectors #644

Closed
wants to merge 4 commits into from

Conversation

julienledem
Copy link
Member

No description provided.

@julienledem julienledem changed the title this is WIP on top of ARROW-824 [ARROW-977][java] Add Timezone aware timestamp vectors May 8, 2017
@julienledem
Copy link
Member Author

@wesm follow up on #568
cleaning up the templates

Change-Id: Iad4f080581382fa95a76cb5f64204111ead09a3d
Change-Id: I6960a9725489d4e9e396ac352d37d731e48de75e
Change-Id: Ibbe3453e3b627b5187c496d91d296e538dd3740d
Change-Id: I060ef92dbb002202cb964280a122a2f4f3ad6fdb
@julienledem
Copy link
Member Author

@wesm rebased

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Can you update the PR title to be ARROW-977: ...

@julienledem julienledem changed the title [ARROW-977][java] Add Timezone aware timestamp vectors ARROW-977: [java] Add Timezone aware timestamp vectors May 15, 2017
@julienledem
Copy link
Member Author

@wesm: fixed. Sorry about that

@asfgit asfgit closed this in 681afab May 15, 2017
@wesm
Copy link
Member

wesm commented May 15, 2017

Since we now have 8 timestamp classes in Java, if there is any way to simplify in the near future to limit the collateral damage in downstream projects of future API changes, that would be great

jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
Author: Julien Le Dem <julien@apache.org>

Closes apache#644 from julienledem/TZ and squashes the following commits:

37987b9 [Julien Le Dem] add integration tests
a58fcae [Julien Le Dem] add integration test
39966aa [Julien Le Dem] add other vectors and tests
bf245ce [Julien Le Dem] add TZ vectors
pcmoritz pushed a commit to pcmoritz/arrow that referenced this pull request Jun 11, 2017
Author: Julien Le Dem <julien@apache.org>

Closes apache#644 from julienledem/TZ and squashes the following commits:

37987b9 [Julien Le Dem] add integration tests
a58fcae [Julien Le Dem] add integration test
39966aa [Julien Le Dem] add other vectors and tests
bf245ce [Julien Le Dem] add TZ vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants