ARROW-7935: [Java] Remove Netty dependency for BufferAllocator and ReferenceManager #6487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
reviewed
Mar 4, 2020
| listener.onAllocation(actualRequestSize); | ||
| return buffer; | ||
| } catch (OutOfMemoryError e) { | ||
| /* |
Contributor
There was a problem hiding this comment.
should this be moved to someplace netty specific?
Contributor
Author
There was a problem hiding this comment.
Thanks for the good suggestion. I have moved it into class PooledByteBufAllocatorL.
Contributor
|
+1 thank you. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…ferenceManager With previous work (ARROW-7329 and ARROW-7505) finished, Netty based allocation is only one of the possible implementations. So we need to revise BufferAllocator and ReferenceManager, to make them general, and independent of Netty libraries. Closes apache#6487 from liyafan82/fly_0225_denet and squashes the following commits: 58e5749 <liyafan82> Move Netty related exception handling to PooledByteBufAllocatorL 5ba874f <liyafan82> Remove Netty dependency for BufferAllocator and ReferenceManager Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous work (ARROW-7329 and ARROW-7505) finished, Netty based allocation is only one of the possible implementations. So we need to revise BufferAllocator and ReferenceManager, to make them general, and independent of Netty libraries.