ARROW-6310: [C++] IPC json should use strings for 64 bit ints #6623
+69
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS can't represent all 64 bit integers as numbers (which are doubles), so store them in the JSON IPC as strings instead. Closes #5267 from bkietz/6310-Write-64-bit-integers-as- and squashes the following commits: 09b6a94 <Benjamin Kietzman> de-nest IntegerColumn 8318e9e <Benjamin Kietzman> rewrite integration/integration_test.py to generate int64 cols as strings 121dee1 <Benjamin Kietzman> use std::to_string a5cd719 <Benjamin Kietzman> ipc json should use strings for 64 bit ints Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Wes McKinney <wesm+git@apache.org>
Member
|
Seems someone opened a PR from a branch on apache/arrow. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS can't represent all 64 bit integers as numbers (which are doubles), so store them in the JSON IPC as strings instead.Closes #5267 from bkietz/6310-Write-64-bit-integers-as- and squashes the following commits:
09b6a94 de-nest IntegerColumn
8318e9e rewrite integration/integration_test.py to generate int64 cols as strings
121dee1 use std::to_string
a5cd719 ipc json should use strings for 64 bit ints
Authored-by: Benjamin Kietzman bengilgit@gmail.com
Signed-off-by: Wes McKinney wesm+git@apache.org