Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32 #669

Closed
wants to merge 1 commit into from
Closed

ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32 #669

wants to merge 1 commit into from

Conversation

bgosztonyi
Copy link
Contributor

__WIN32 is not standard for all windows compilers.

@bgosztonyi
_WIN32 instead of __WIN32
618ab3e 
__WIN32 is not standard for all windows compilers.
@bgosztonyi bgosztonyi changed the title define _WIN32 instead of __WIN32 Check flag _WIN32 instead of __WIN32 May 10, 2017
@wesm
Copy link
Member

wesm commented May 10, 2017

@bgosztonyi can you open a JIRA and add it to the PR title? Thanks!

https://github.com/apache/arrow#how-to-contribute

@bgosztonyi bgosztonyi changed the title Check flag _WIN32 instead of __WIN32 ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32 May 10, 2017
wesm
wesm approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I will merge when the build runs -- if you activate Appveyor on your fork, you can get more timely builds

@asfgit asfgit closed this in c10b7d7 May 11, 2017
@wesm
Copy link
Member

wesm commented May 11, 2017

Thanks for your contribution

jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
@bgosztonyi @jeffknupp
ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32
83eb24e 
__WIN32 is not standard for all windows compilers.

Author: bgosztonyi <b.alazsgosztonyi@gmail.com>

Closes apache#669 from bgosztonyi/patch-1 and squashes the following commits:

618ab3e [bgosztonyi] _WIN32 instead of __WIN32
pcmoritz pushed a commit to pcmoritz/arrow that referenced this pull request Jun 11, 2017
@bgosztonyi @pcmoritz
ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32
7394c8b 
__WIN32 is not standard for all windows compilers.

Author: bgosztonyi <b.alazsgosztonyi@gmail.com>

Closes apache#669 from bgosztonyi/patch-1 and squashes the following commits:

618ab3e [bgosztonyi] _WIN32 instead of __WIN32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgosztonyi @wesm