ARROW-1027: [Python] Allow negative indexing in fields/columns on pyarrow Table and Schema objects #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrow Table and Schema objects
wesm
approved these changes
May 15, 2017
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
…rrow Table and Schema objects Negative indexing causes an interpreter segfault right now. After this PR, no segfaults, and reasonable error messages for out of bounds indexes. Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#686 from cpcloud/ARROW-1027 and squashes the following commits: 1bfcef4 [Phillip Cloud] ARROW-1027: [Python] Allow negative indexing in fields/columns on pyarrow Table and Schema objects
pcmoritz
pushed a commit
to pcmoritz/arrow
that referenced
this pull request
Jun 11, 2017
…rrow Table and Schema objects Negative indexing causes an interpreter segfault right now. After this PR, no segfaults, and reasonable error messages for out of bounds indexes. Author: Phillip Cloud <cpcloud@gmail.com> Closes apache#686 from cpcloud/ARROW-1027 and squashes the following commits: 1bfcef4 [Phillip Cloud] ARROW-1027: [Python] Allow negative indexing in fields/columns on pyarrow Table and Schema objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative indexing causes an interpreter segfault right now. After this PR, no segfaults, and reasonable error messages for out of bounds indexes.