Skip to content

ARROW-990: [JS] Add tslint support for linting TypeScript #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheNeuralBit wants to merge 10 commits into from
Closed

ARROW-990: [JS] Add tslint support for linting TypeScript #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d591b3c
add tslint config
May 9, 2017
81c9868
Replace vars with let/const, one def per line
May 9, 2017
2b4ff28
added public, private, protected to all members
May 29, 2017
c5d85f7
whitespace, semicolons, Errors
May 29, 2017
08d60e6
quotes, equality checks
May 29, 2017
0a1b872
fix public, private, protected ordering issues
May 29, 2017
67d82ca
variable names, object shorthand
May 29, 2017
6f1583e
sort object literals
May 29, 2017
68b7c8f
misc tslint fixes
May 29, 2017
727d80f
added npm lint script
May 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions js/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ From this directory, run:

``` bash
$ npm install # pull dependencies
$ npm run lint -- <filename> # run tslint
$ npm run build # build typescript (run tsc and webpack)
$ npm run test # run the unit tests (node.js only)
```
Expand Down
4 changes: 3 additions & 1 deletion js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"scripts": {
"build": "./flatbuffers.sh && tsc && tsc -m es6 --outDir lib-esm && webpack",
"clean": "rm -rf lib lib-esm _bundles",
"test": "./node_modules/mocha/bin/mocha ./spec/arrow.js"
"test": "./node_modules/mocha/bin/mocha ./spec/arrow.js",
"lint": "./node_modules/tslint/bin/tslint"
},
"author": "",
"repository": "https://github.com/apache/arrow/",
Expand All @@ -15,6 +16,7 @@
"awesome-typescript-loader": "^3.1.3",
"chai": "^3.5.0",
"mocha": "^3.3.0",
"tslint": "^5.3.2",
"typescript": "^2.3.2",
"uglifyjs-webpack-plugin": "^0.4.3",
"webpack": "^2.3.3"
Expand Down
Loading