ARROW-9192: [CI][Rust] Add support for running clippy #7501
Conversation
houqp
changed the title
|
Hm I think this lint step should be merged into the main Lint workflow. @kszucs can you help? |
|
@kszucs let me know if there is anything i can help to move it to the main lint workflow. |
|
@kszucs gentle ping, let me know what's the best way for me to help. |
It would be nice to have it integrated to archery, but since it's only triggered for the rust changes I think it's fine to defer it to a follow-up. Created ARROW-9295: [Archery] Support rust clippy in the lint command. |
|
@houqp sorry for the late response. I moved the lint job to the macos build to spare some CI resource and also changed to check all crates. |
kszucs
changed the title
|
Created another follow-up to enable more clippy rules: ARROW-9296: [CI][Rust] Enable more clippy lint checks |
|
Thanks @kszucs , at the mean time, I will try to fix more linting errors and see if we can just run clippy as is without the custom linting script before you start adding it to Archery. |
The goal of this PR is not to fix all the clippy errors/warnings in arrow crate, but to make sure no new linting errors are introduced in the future so we can slowly fix the remaining errors. Closes apache#7501 from houqp/ARROW-9192 Lead-authored-by: Qingping Hou <dave2008713@gmail.com> Co-authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
The goal of this PR is not to fix all the clippy errors/warnings in arrow crate, but to make sure no new linting errors are introduced in the future so we can slowly fix the remaining errors.