Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-10225: [Rust] [Parquet] Fix null comparison in roundtrip #8388

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ARROW-10225: [Rust] [Parquet] Fix null comparison in roundtrip
  • Loading branch information
nevi-me committed Oct 7, 2020
commit f9cad7d80bd73dbb42121a35c63d714145a9aaf4
10 changes: 6 additions & 4 deletions rust/parquet/src/arrow/arrow_writer.rs
Original file line number Diff line number Diff line change
@@ -724,7 +724,11 @@ mod tests {
assert_eq!(expected_data.offset(), actual_data.offset());
assert_eq!(expected_data.buffers(), actual_data.buffers());
assert_eq!(expected_data.child_data(), actual_data.child_data());
assert_eq!(expected_data.null_bitmap(), actual_data.null_bitmap());
// Null counts should be the same, not necessarily bitmaps
// A null bitmap is optional if an array has no nulls
if expected_data.null_count() != 0 {
assert_eq!(expected_data.null_bitmap(), actual_data.null_bitmap());
}
}
}

@@ -1001,7 +1005,7 @@ mod tests {
}

#[test]
#[ignore] // Binary support isn't correct yet - null_bitmap doesn't match
#[ignore] // Binary support isn't correct yet - buffers don't match
fn binary_single_column() {
let one_vec: Vec<u8> = (0..SMALL_SIZE as u8).collect();
let many_vecs: Vec<_> = std::iter::repeat(one_vec).take(SMALL_SIZE).collect();
@@ -1026,7 +1030,6 @@ mod tests {
}

#[test]
#[ignore] // String support isn't correct yet - null_bitmap doesn't match
fn string_single_column() {
let raw_values: Vec<_> = (0..SMALL_SIZE).map(|i| i.to_string()).collect();
let raw_strs = raw_values.iter().map(|s| s.as_str());
@@ -1035,7 +1038,6 @@ mod tests {
}

#[test]
#[ignore] // Large string support isn't correct yet - null_bitmap doesn't match
fn large_string_single_column() {
let raw_values: Vec<_> = (0..SMALL_SIZE).map(|i| i.to_string()).collect();
let raw_strs = raw_values.iter().map(|s| s.as_str());