ARROW-219: Preserve CMAKE_CXX_FLAGS, fix compiler warnings #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, LGTM |
|
+1 |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
I adapted @emkornfield's work from ARROW-71 (apache@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future. Author: Wes McKinney <wesm@apache.org> Closes apache#92 from wesm/PARQUET-477 and squashes the following commits: 8b6e8f0 [Wes McKinney] Statically-link zlib 503e793 [Wes McKinney] Boost 1.55 2c512dc [Wes McKinney] Install newer boost due to C++11 issues on ubuntu precise 514601c [Wes McKinney] Fix build dir in travis script 6c2e7cf [Wes McKinney] Adapt clang-tidy / clang-format tools from Apache Arrow C++ codebase
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
I adapted @emkornfield's work from ARROW-71 (apache@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future. Author: Wes McKinney <wesm@apache.org> Closes apache#92 from wesm/PARQUET-477 and squashes the following commits: 8b6e8f0 [Wes McKinney] Statically-link zlib 503e793 [Wes McKinney] Boost 1.55 2c512dc [Wes McKinney] Install newer boost due to C++11 issues on ubuntu precise 514601c [Wes McKinney] Fix build dir in travis script 6c2e7cf [Wes McKinney] Adapt clang-tidy / clang-format tools from Apache Arrow C++ codebase Change-Id: I5f7cbe5be7e898b5c522d0f67c8b934ce7d9dab1
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
I adapted @emkornfield's work from ARROW-71 (apache@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future. Author: Wes McKinney <wesm@apache.org> Closes apache#92 from wesm/PARQUET-477 and squashes the following commits: 8b6e8f0 [Wes McKinney] Statically-link zlib 503e793 [Wes McKinney] Boost 1.55 2c512dc [Wes McKinney] Install newer boost due to C++11 issues on ubuntu precise 514601c [Wes McKinney] Fix build dir in travis script 6c2e7cf [Wes McKinney] Adapt clang-tidy / clang-format tools from Apache Arrow C++ codebase Change-Id: I5f7cbe5be7e898b5c522d0f67c8b934ce7d9dab1
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
I adapted @emkornfield's work from ARROW-71 (apache@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future. Author: Wes McKinney <wesm@apache.org> Closes apache#92 from wesm/PARQUET-477 and squashes the following commits: 8b6e8f0 [Wes McKinney] Statically-link zlib 503e793 [Wes McKinney] Boost 1.55 2c512dc [Wes McKinney] Install newer boost due to C++11 issues on ubuntu precise 514601c [Wes McKinney] Fix build dir in travis script 6c2e7cf [Wes McKinney] Adapt clang-tidy / clang-format tools from Apache Arrow C++ codebase Change-Id: I5f7cbe5be7e898b5c522d0f67c8b934ce7d9dab1
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
I adapted @emkornfield's work from ARROW-71 (apache@5d12999). It's a large diff due to the first reformatting of the codebase. Per travis-ci/apt-source-safelist#199 we can switch Travis back to Ubuntu 14.04 and maybe upgrade to LLVM 3.8 at some point in the future. Author: Wes McKinney <wesm@apache.org> Closes apache#92 from wesm/PARQUET-477 and squashes the following commits: 8b6e8f0 [Wes McKinney] Statically-link zlib 503e793 [Wes McKinney] Boost 1.55 2c512dc [Wes McKinney] Install newer boost due to C++11 issues on ubuntu precise 514601c [Wes McKinney] Fix build dir in travis script 6c2e7cf [Wes McKinney] Adapt clang-tidy / clang-format tools from Apache Arrow C++ codebase Change-Id: I5f7cbe5be7e898b5c522d0f67c8b934ce7d9dab1
praveenbingo
pushed a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 10, 2018
praveenbingo
pushed a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 10, 2018
praveenbingo
pushed a commit
to praveenbingo/arrow
that referenced
this pull request
Sep 10, 2018
zhouyuan
added a commit
to zhouyuan/arrow
that referenced
this pull request
Nov 18, 2020
[oap-native-sql] support spark_hash and isNaN in gandiva
zhouyuan
pushed a commit
to zhouyuan/arrow
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some undesired compiler warnings had crept into our build; future warnings should fail the build now.