ARROW-9451: [Python] Refuse implicit cast of str to unsigned integer #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that `pa.array(['5'], type='uint32')` raises an exception.
|
It's good to make this consistent for signed vs unsigned integer types. |
|
I'm not fond of lax conversions. Much better to have people explicitly cast if they want to, IMHO. |
|
Sounds good, as long as we are consistent. |
jorisvandenbossche
approved these changes
Apr 6, 2021
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
Ensure that `pa.array(['5'], type='uint32')` raises an exception. Closes apache#9912 from pitrou/ARROW-9451-implicit-str-to-int Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 10, 2021
Ensure that `pa.array(['5'], type='uint32')` raises an exception. Closes apache#9912 from pitrou/ARROW-9451-implicit-str-to-int Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Ensure that `pa.array(['5'], type='uint32')` raises an exception. Closes apache#9912 from pitrou/ARROW-9451-implicit-str-to-int Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
pa.array(['5'], type='uint32')raises an exception.