Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-12262: [Doc] Enable S3 and Flight in docs build #9933

Closed
wants to merge 3 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 7, 2021

Also use Ubuntu 20.04 by default, instead of 18.04.

@pitrou
Copy link
Member Author

pitrou commented Apr 7, 2021

The Python Flight API docs still fail generating because of:

# python
Python 3.8.5 (default, Jan 27 2021, 15:41:15) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in <module>
    from pyarrow._flight import (  # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>> 

# c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*)

@pitrou pitrou requested review from kszucs and kou April 7, 2021 16:44
@pitrou
Copy link
Member Author

pitrou commented Apr 7, 2021

For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/

@pitrou
Copy link
Member Author

pitrou commented Apr 7, 2021

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

@kszucs
Copy link
Member

kszucs commented Apr 7, 2021

I wonder if we can use Ubuntu's libgrpc++-dev package instead of building from source. As a bonus, the build would be faster...

You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile

@pitrou
Copy link
Member Author

pitrou commented Apr 7, 2021

Ok, it doesn't seem to work:

  • we need a more recent libprotobuf than 20.04 provides
  • our CMake build can't find Ubuntu's gRPC or c-ares libraries anyway :-/

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.

docs/source/status.rst Show resolved Hide resolved
@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

Our packages for Ubuntu 20.10 use system gRPC.

That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...

# ldd /usr/local/lib/libarrow_flight.so.400.0.0 | grep ares
	libcares.so.2 => /lib/x86_64-linux-gnu/libcares.so.2 (0x00007f3d253bb000)

@kou
Copy link
Member

kou commented Apr 8, 2021

Ah, it's a bug of our CMake script.
We need to find system c-ares by pkg-config too.

Do you want me to create a patch for it?

@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

That would be nice, yes :-)

@kou
Copy link
Member

kou commented Apr 8, 2021

OK. I'll work on it.

@pitrou pitrou force-pushed the ARROW-12262-ubuntu-docs branch from 5e79f8f to afd1324 Compare April 8, 2021 08:26
@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Revision: afd1324

Submitted crossbow builds: ursacomputing/crossbow @ actions-285

Task Status
test-ubuntu-20.10-docs Azure

@pitrou pitrou force-pushed the ARROW-12262-ubuntu-docs branch from afd1324 to 971b698 Compare April 8, 2021 09:12
@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Revision: 971b698

Submitted crossbow builds: ursacomputing/crossbow @ actions-286

Task Status
test-ubuntu-20.10-docs Azure

@pitrou pitrou force-pushed the ARROW-12262-ubuntu-docs branch from 971b698 to 73993bd Compare April 8, 2021 13:36
@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Revision: 73993bd

Submitted crossbow builds: ursacomputing/crossbow @ actions-297

Task Status
test-ubuntu-20.10-docs Azure

@pitrou pitrou force-pushed the ARROW-12262-ubuntu-docs branch from 73993bd to 9ccb811 Compare April 8, 2021 18:01
@pitrou
Copy link
Member Author

pitrou commented Apr 8, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Revision: 9ccb811

Submitted crossbow builds: ursacomputing/crossbow @ actions-299

Task Status
test-ubuntu-20.10-docs Azure

@kou
Copy link
Member

kou commented Apr 10, 2021

c-ares improvement: #9977

@kszucs kszucs force-pushed the ARROW-12262-ubuntu-docs branch from 9ccb811 to 571df57 Compare April 13, 2021 10:59
@kszucs
Copy link
Member

kszucs commented Apr 13, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

Revision: 1720a07

Submitted crossbow builds: ursacomputing/crossbow @ actions-316

Task Status
test-ubuntu-20.10-docs Azure

@pitrou
Copy link
Member Author

pitrou commented Apr 13, 2021

Crossbow failed unrelatedly in the Java build :-/

@kou
Copy link
Member

kou commented Apr 14, 2021

@github-actions crossbow submit test-ubuntu-20.10-docs

@github-actions
Copy link

Revision: 1720a07

Submitted crossbow builds: ursacomputing/crossbow @ actions-319

Task Status
test-ubuntu-20.10-docs Azure

@pitrou
Copy link
Member Author

pitrou commented Apr 14, 2021

Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge.

@pitrou pitrou force-pushed the ARROW-12262-ubuntu-docs branch from 1720a07 to 47ef976 Compare April 14, 2021 13:06
@pitrou pitrou closed this in 31c8c75 Apr 14, 2021
@pitrou pitrou deleted the ARROW-12262-ubuntu-docs branch April 14, 2021 13:07
Dandandan pushed a commit to Dandandan/arrow that referenced this pull request Apr 14, 2021
Also use Ubuntu 20.04 by default, instead of 18.04.

Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
GeorgeAp pushed a commit to sirensolutions/arrow that referenced this pull request Jun 7, 2021
Also use Ubuntu 20.04 by default, instead of 18.04.

Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 10, 2021
Also use Ubuntu 20.04 by default, instead of 18.04.

Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
michalursa pushed a commit to michalursa/arrow that referenced this pull request Jun 13, 2021
Also use Ubuntu 20.04 by default, instead of 18.04.

Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants