-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12262: [Doc] Enable S3 and Flight in docs build #9933
Conversation
The Python Flight API docs still fail generating because of: # python
Python 3.8.5 (default, Jan 27 2021, 15:41:15)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyarrow
>>> import pyarrow.flight
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.8/dist-packages/pyarrow/flight.py", line 18, in <module>
from pyarrow._flight import ( # noqa:F401
ImportError: /usr/local/lib/libarrow_flight.so.400: undefined symbol: _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
>>>
# c++filt _ZN4absl14lts_2020_09_2319str_format_internal13FormatArgImpl8DispatchINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbNS2_4DataENS1_24FormatConversionSpecImplEPv
bool absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Dispatch<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(absl::lts_2020_09_23::str_format_internal::FormatArgImpl::Data, absl::lts_2020_09_23::str_format_internal::FormatConversionSpecImpl, void*) |
For the C++ and Python side at least, it would be easier to use a Conda-based build... but I don't know how that would work for R :-/ |
I wonder if we can use Ubuntu's |
You could try it by adding libgrpc to the ubuntu-20.04-cpp.dockerfile |
Ok, it doesn't seem to work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use system gRPC with Ubuntu 20.10.
Our packages for Ubuntu 20.10 use system gRPC.
That seems to work. However, c-ares still needs to be built from source. Is there a reason for that? I see that the Flight library links to the system c-ares...
|
Ah, it's a bug of our CMake script. Do you want me to create a patch for it? |
That would be nice, yes :-) |
OK. I'll work on it. |
5e79f8f
to
afd1324
Compare
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: afd1324 Submitted crossbow builds: ursacomputing/crossbow @ actions-285
|
afd1324
to
971b698
Compare
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: 971b698 Submitted crossbow builds: ursacomputing/crossbow @ actions-286
|
971b698
to
73993bd
Compare
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: 73993bd Submitted crossbow builds: ursacomputing/crossbow @ actions-297
|
73993bd
to
9ccb811
Compare
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: 9ccb811 Submitted crossbow builds: ursacomputing/crossbow @ actions-299
|
c-ares improvement: #9977 |
9ccb811
to
571df57
Compare
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: 1720a07 Submitted crossbow builds: ursacomputing/crossbow @ actions-316
|
Crossbow failed unrelatedly in the Java build :-/ |
@github-actions crossbow submit test-ubuntu-20.10-docs |
Revision: 1720a07 Submitted crossbow builds: ursacomputing/crossbow @ actions-319
|
Ok, I don't think the Java failures should block this PR (we may also disable building the Java docs if that's required to upload the 4.0.0 docs). Will merge. |
Also use Ubuntu 20.04 by default, instead of 18.04.
1720a07
to
47ef976
Compare
Also use Ubuntu 20.04 by default, instead of 18.04. Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also use Ubuntu 20.04 by default, instead of 18.04. Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also use Ubuntu 20.04 by default, instead of 18.04. Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also use Ubuntu 20.04 by default, instead of 18.04. Closes apache#9933 from pitrou/ARROW-12262-ubuntu-docs Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Also use Ubuntu 20.04 by default, instead of 18.04.