Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3175 Rust: fix lint/clippy errors #1286

Merged
merged 9 commits into from
Aug 7, 2021

Conversation

martin-g
Copy link
Member

@martin-g martin-g commented Jul 7, 2021

Fix all linting/clippy errors & warnings.
Add build.sh for Rust that currently supports clean, dist, lint and test targets

Jira

Tests

Tests' source code has been updated to fix linting/clippy errors and warnings

Commits

Documentation

No public facing API has been modified. No need of documentation changes!

Fix all linting/clippy errors & warnings.
Add build.sh for Rust that currently supports clean, dist, lint and test targets
@martin-g
Copy link
Member Author

martin-g commented Jul 8, 2021

Cool! GitHub Actions now work too!
Only the Security Audit does not work because it looks for Cargo.toml only in the root folder. There is an open issue: actions-rs/audit-check#116

@martin-g
Copy link
Member Author

Any feedback on the proposed changes ?
//CC @iemejia

@iemejia
Copy link
Member

iemejia commented Jul 29, 2021

My biggest excuses @martin-g I had checked at this PR like 3 weeks ago and I thought I had approved/merged it, and then I went on holidays. It LGTM I just want to do a tiny ping to @flavray in case he might have some extra comment before merging it.

Thanks (and sorry for the delay, lots of things ongoing these last weeks for me).

@martin-g
Copy link
Member Author

No need to apologies, @iemejia !
Thanks!

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit d1b4810 into apache:master Aug 7, 2021
@iemejia
Copy link
Member

iemejia commented Aug 7, 2021

Arghh sorry these have been quite busy days and I somehow missed the notification. Review/Work pace should be back to normal now. Thanks for this one @martin-g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants