-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3175 Rust: fix lint/clippy errors #1286
Conversation
Fix all linting/clippy errors & warnings. Add build.sh for Rust that currently supports clean, dist, lint and test targets
Use --manifest-path to specify the path to Cargo.yaml
This should fix the Github Actions CI workflow
Cool! GitHub Actions now work too! |
Any feedback on the proposed changes ? |
My biggest excuses @martin-g I had checked at this PR like 3 weeks ago and I thought I had approved/merged it, and then I went on holidays. It LGTM I just want to do a tiny ping to @flavray in case he might have some extra comment before merging it. Thanks (and sorry for the delay, lots of things ongoing these last weeks for me). |
No need to apologies, @iemejia ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Arghh sorry these have been quite busy days and I somehow missed the notification. Review/Work pace should be back to normal now. Thanks for this one @martin-g |
Fix all linting/clippy errors & warnings.
Add
build.sh
for Rust that currently supports clean, dist, lint and test targetsJira
Tests
Tests' source code has been updated to fix linting/clippy errors and warnings
Commits
Documentation
No public facing API has been modified. No need of documentation changes!