Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3250: Support .NET 6.0 #1394

Merged
merged 4 commits into from
Jan 10, 2022
Merged

AVRO-3250: Support .NET 6.0 #1394

merged 4 commits into from
Jan 10, 2022

Conversation

zcsizmadia
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@martin-g
Copy link
Member

martin-g commented Nov 9, 2021

It seems GitHub Actions does not yet provide v6

@zcsizmadia
Copy link
Contributor Author

I am not sure how the gitflow test will use the latest dotnet 6.0. I dont see any reference to specify to install any of the dotnet sdks into the gitflow. I am not sure what I am missing

@zcsizmadia
Copy link
Contributor Author

Maybe we should have setup-dotnet added to the dotnet gitflow tests (https://github.com/actions/setup-dotnet)

@martin-g
Copy link
Member

martin-g commented Nov 9, 2021

Either this or wait few days until GHA people add it to their images. I guess .NET is popular at GitHub :-)

@zcsizmadia
Copy link
Contributor Author

Added the .NET SDK dependencies to the github actions. (suggested by https://blog.elmah.io/building-and-testing-on-multiple-net-versions-with-github-actions/). This seems more solid, to explicitly installing it, so we dont depend on SDKS included in the latest github ubuntu image. (Which I thought was a bare image anyway)

@martin-g
Copy link
Member

martin-g commented Nov 9, 2021

No, it is not a bare image.
See the table at https://github.com/actions/virtual-environments/#available-environments.
At the moment it is build 20211108.1

@zcsizmadia
Copy link
Contributor Author

zcsizmadia commented Nov 9, 2021

actions/runner-images#4424 (comment)

This suggests, that it is probably a good idea to install the .NET SDKs explicitly and not relying on the base image.

@ostsmolynets
Copy link

Hi, we are moving our projects to .net 6 and depend on Avro.Tools in some of them.
It's great to see you guys already working on the support for the new version.
Would be really nice to know if the support is coming any time soon?

@martin-g martin-g merged commit 7b8f20c into apache:master Jan 10, 2022
martin-g pushed a commit that referenced this pull request Jan 10, 2022
* Support .NET 6.0

* Add .NET SDKs to C# gitflow

* Use latest setup-dotnet action step to install multiple SDKs

* Change gitflow step names

Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
(cherry picked from commit 7b8f20c)
@martin-g
Copy link
Member

Thank you for the contribution, @zcsizmadia !

@zcsizmadia zcsizmadia deleted the avro-3250-support-net-6 branch January 10, 2022 14:45
@zcsizmadia
Copy link
Contributor Author

@martin-g Do you have an estimate when 1.11.1 would be released? We are using avrogen and would like to move to net6, but avrogen is holding us back.

@martin-g
Copy link
Member

martin-g commented Jan 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants