Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2771: Refactor custom codable check #1720

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

opwvhk
Copy link
Contributor

@opwvhk opwvhk commented Jun 13, 2022

Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    org.apache.avro.specific.TestGeneratedCode#withErrorField

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added build Java Pull Requests for Java binding labels Jun 13, 2022
@opwvhk opwvhk force-pushed the AVRO-2771-allow-error-field-in-record branch from 2fb8f43 to 20026f0 Compare November 7, 2022 09:46
Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.
@opwvhk opwvhk force-pushed the AVRO-2771-allow-error-field-in-record branch from 1174084 to b034eb6 Compare November 11, 2022 15:03
@opwvhk opwvhk merged commit 52d9339 into apache:master Aug 15, 2023
@opwvhk opwvhk deleted the AVRO-2771-allow-error-field-in-record branch August 15, 2023 19:19
@opwvhk opwvhk restored the AVRO-2771-allow-error-field-in-record branch August 15, 2023 19:27
opwvhk added a commit to opwvhk/avro that referenced this pull request Aug 15, 2023
* AVRO-2771: Refactor custom codable check

Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.
opwvhk added a commit to opwvhk/avro that referenced this pull request Aug 15, 2023
* AVRO-2771: Refactor custom codable check

Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.
opwvhk added a commit to opwvhk/avro that referenced this pull request Aug 16, 2023
* AVRO-2771: Refactor custom codable check

Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.
@opwvhk opwvhk deleted the AVRO-2771-allow-error-field-in-record branch September 26, 2023 14:35
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
* AVRO-2771: Refactor custom codable check

Moved the isError check for the "custom codable" check to fix a
backwards compatibility issue between versions 1.8.x & 1.9.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant