AVRO-3748 [java] fix SeekableInputStream.skip #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clesaec
reviewed
May 2, 2023
lang/java/avro/src/main/java/org/apache/avro/file/DataFileReader.java
Outdated
Show resolved
Hide resolved
steven-aerts
force-pushed
the
AVRO-3748
branch
2 times, most recently
from
eb9db9d
to
de24e81
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| w.write("someContent"); | ||
| } | ||
| try(DataFileReader.SeekableInputStream stream = | ||
| new DataFileReader.SeekableInputStream(new SeekableFileInput(f)) |
Check warning
Code scanning / CodeQL
Potential input resource leak
| try(DataFileReader.SeekableInputStream stream = | ||
| new DataFileReader.SeekableInputStream(new SeekableFileInput(f)) | ||
| ) { | ||
| for (int i = 0; i < stream.length(); i++) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
The implementation of SeekableInputStream.skip had a longstantind issue that it did a seek to a wrong position. This issue is rather difficult to hit in avro as it is only used in corner cases of for example the FastReader.
clesaec
added a commit
that referenced
this pull request
Aug 16, 2023
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
The implementation of SeekableInputStream.skip had a longstantind issue that it did a seek to a wrong position. This issue is rather difficult to hit in avro as it is only used in corner cases of for example the FastReader.
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…pache#2446) This reverts commit 33631e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of SeekableInputStream.skip had a longstantind issue that it did a seek to a wrong position.
This issue is rather difficult to hit in avro as it is only used in corner cases of for example the FastReader.
What is the purpose of the change
Verifying this change
This change added a test to verify the new behavior
Documentation