AVRO-3985: Add trusted packages support in SpecificData #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Jun 2, 2024
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java
Outdated
Show resolved
Hide resolved
martin-g
reviewed
Jun 3, 2024
lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflect.java
Outdated
Show resolved
Hide resolved
lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflectData.java
Outdated
Show resolved
Hide resolved
jbonofre
force-pushed
the
AVRO-3985
branch
4 times, most recently
from
78142bb to
9991b78
Compare
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Outdated
Show resolved
Hide resolved
|
@Fokko @martin-g @KalleOlaviNiemitalo I updated the PR. Can you guys please take a look ? Thanks ! |
martin-g
reviewed
Jun 14, 2024
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Outdated
Show resolved
Hide resolved
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Outdated
Show resolved
Hide resolved
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Outdated
Show resolved
Hide resolved
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Show resolved
Hide resolved
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Outdated
Show resolved
Hide resolved
Fokko
reviewed
Jun 19, 2024
lang/java/avro/src/main/java/org/apache/avro/specific/SpecificDatumReader.java
Show resolved
Hide resolved
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
martin-g
approved these changes
Jun 20, 2024
|
Moving this forward, thanks @jbonofre for fixing this 🙌 and thanks @martin-g and @KalleOlaviNiemitalo for the reviews! |
|
I'm creating the 1.11.x backport PR. |
MichalFoksa
reviewed
Jan 6, 2025
|
|
||
| boolean found = false; | ||
| Package thePackage = clazz.getPackage(); | ||
| if (thePackage != null) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I can take a look on this too as I'm the original author
There was a problem hiding this comment.
@MichalFoksa Would you like to send a Pull Request?
There was a problem hiding this comment.
Else I can work on a PR tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change introduces the
org.apache.avro.SERIALIZABLE_PACKAGESsystem property to enforce the security aspect of usingjava-classin a schema.Verifying this change
This change is already covered by existing tests, using the default trusted packages. I can add an additional test specifically for non trusted packages.
Documentation
org.apache.avro.SERIALIZABLE_PACKAGESsystem property. Happy to add additional documentation if needed.