-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Avro-2785: Update specs on how unions encoded #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve the conflicts @anhldbk ?
|
@Fokko What should I do? I agree with Roger's comment |
|
I can't merge the PR, there is a merge conflict in |
|
@Fokko PTAL :) |
|
@anhldbk I see a lot of unrelated changes in |
|
@Fokko I've got troubles with my Python formatter. Gonna resolve it and tell you later |
|
@Fokko actualluy my latest commit fixed the λ git diff AVRO-2785 upstream/master -- lang/py/avro/io.py
diff --git a/lang/py/avro/io.py b/lang/py/avro/io.py
index e165db3a..b910ba56 100644
--- a/lang/py/avro/io.py
+++ b/lang/py/avro/io.py
@@ -846,7 +846,7 @@ class DatumReader(object):
def read_union(self, writers_schema, readers_schema, decoder):
"""
- A union is encoded by first writing an int value indicating
+ A union is encoded by first writing a long value indicating
the zero-based position within the union of the schema of its value.
The value is then encoded per the indicated schema within the union.
"""
@@ -1096,7 +1096,7 @@ class DatumWriter(object):
def write_union(self, writers_schema, datum, encoder):
"""
- A union is encoded by first writing an int value indicating
+ A union is encoded by first writing a long value indicating
the zero-based position within the union of the schema of its value.
The value is then encoded per the indicated schema within the union.
""" |
|
Looks good to me. Thanks for contributing! |
|
Thanks @anhldbk |
My PR addresses the following issue Avro-2785