Merge pull request #25073: Improves StorageWrite API error logging

apache · Jan 19, 2023 · 876ce5b · 876ce5b
1 parent 1c4e424
commit 876ce5b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java b/...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java
@@ -490,7 +490,7 @@ long flush(
               }
 
               LOG.warn(
-                  "Append to stream {} by client #{} failed with error, operations will be retried. Details: {}",
+                  "Append to stream {} by client #{} failed with error, operations will be retried.\n{}",
                   streamName,
                   clientNumber,
                   retrieveErrorDetails(contexts));
@@ -510,8 +510,13 @@ String retrieveErrorDetails(Iterable<AppendRowsContext> failedContext) {
         return StreamSupport.stream(failedContext.spliterator(), false)
             .<@Nullable Throwable>map(AppendRowsContext::getError)
             .filter(err -> err != null)
-            .flatMap(thrw -> Arrays.stream(Preconditions.checkStateNotNull(thrw).getStackTrace()))
-            .map(StackTraceElement::toString)
+            .map(
+                thrw ->
+                    Preconditions.checkStateNotNull(thrw).toString()
+                        + "\n"
+                        + Arrays.stream(Preconditions.checkStateNotNull(thrw).getStackTrace())
+                            .map(StackTraceElement::toString)
+                            .collect(Collectors.joining("\n")))
             .collect(Collectors.joining("\n"));
       }
     }