Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find Proto getters in certain cases #21626

Closed
damccorm opened this issue Jun 5, 2022 · 0 comments · Fixed by #17775
Closed

Unable to find Proto getters in certain cases #21626

damccorm opened this issue Jun 5, 2022 · 0 comments · Fixed by #17775
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. extensions java P2 protobuf

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 5, 2022

Proto property name: item2partner_id 

Generated java library method names:

  • hasItem2PartnerId
  • getItem2PartnerId
  • setItem2PartnerId
  • clearItem2PartnerId

org.apache.beam.sdk.extensions.protobuf.ProtoByteBuddyUtils generated getter name:

  • getItem2partnerId

 

Notice the case difference of 'p'. The getter method name creation isn't aligned with protobuf standards.

See:

 

According this logic anything that isn't A-Za-z makes the next character uppercase.

Imported from Jira BEAM-14525. Original Jira may contain additional context.
Reported by: bnemeth.

kileys added a commit that referenced this issue Jul 21, 2022
[BEAM-14525] / #21626 Fix for Protobuf getter/setter method name discovery issue
@chamikaramj chamikaramj added the done & done Issue has been reviewed after it was closed for verification, followups, etc. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug done & done Issue has been reviewed after it was closed for verification, followups, etc. extensions java P2 protobuf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants